Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer Buildbot workers from environment #722

Closed

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Sep 28, 2017

Use a dictionary for the lookup.
Make the Environment class (mostly) immutable and hashable to allow
using environment as dictionary keys.


This change is Reviewable

@aneeshusa
Copy link
Member Author

aneeshusa commented Sep 28, 2017

@jdm
Copy link
Member

jdm commented Oct 18, 2017

This looks fine to me.

@jdm
Copy link
Member

jdm commented Oct 18, 2017

However:

[ FAIL ] Buildbot master config check failed:

         Configuration Errors:

           configuration file '/home/servo/buildbot/master/master.cfg' does not exist

[ FAIL ] Buildbot master config lint check failed:

         ./buildbot/master/files/config/environments.py:25:12: E111 indentation is not a multiple of four

         ./buildbot/master/files/config/environments.py:26:12: E111 indentation is not a multiple of four
@jdm
Copy link
Member

jdm commented Oct 18, 2017

Renaming the configuration file will require further changes elsewhere.

@jdm jdm assigned jdm and unassigned metajack Oct 18, 2017
aneeshusa added 2 commits Sep 28, 2017
Use a dictionary for the lookup.
Make the Environment class (mostly) immutable and hashable to allow
using environment as dictionary keys.
@aneeshusa aneeshusa force-pushed the aneeshusa:infer-builders-from-environment branch from 2c45ddb to 81e1d58 Oct 19, 2017
@aneeshusa
Copy link
Member Author

aneeshusa commented Oct 19, 2017

Oops, renaming the file was meant to be a local-only change for debugging, I had inadvertently committed that before and have removed it now. Yay for tests that catch silly mistakes!

@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2018

The latest upstream changes (presumably #850) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm jdm closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.