Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInfer Buildbot workers from environment #722
Closed
Conversation
|
r? @metajack per #721 (review) |
|
This looks fine to me. |
|
However:
|
|
Renaming the configuration file will require further changes elsewhere. |
2c45ddb
to
81e1d58
|
Oops, renaming the file was meant to be a local-only change for debugging, I had inadvertently committed that before and have removed it now. Yay for tests that catch silly mistakes! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedSep 28, 2017
•
edited by larsbergstrom
Use a dictionary for the lookup.
Make the Environment class (mostly) immutable and hashable to allow
using environment as dictionary keys.
This change is