Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid installing sccache on servo-master #723
Merged
+6
−3
Conversation
|
Follow-up to #688. r? @larsbergstrom |
|
Note that when deploying the previous PR, I intentionally did not run the sccache state on |
|
This lgtm - thanks, aneesh! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 29, 2017
…r=larsbergstrom Avoid installing sccache on servo-master <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/723) <!-- Reviewable:end -->
|
|
|
Looked into the build failure here; we need #724 to be able to merge anything into saltfs. |
|
r=me once 724 lands |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Sep 30, 2017
…r=larsbergstrom Avoid installing sccache on servo-master <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/723) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedSep 28, 2017
•
edited by larsbergstrom
This change is