Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle Homebrew renaming `mobile-shell` to `mosh` #724
Conversation
Homebrew left in an alias for `mobile-shell` so the `mosh` package actually installs correctly, but Salt's pkg.installed state then tries to verify the installation by checking the installed packages. That list only shows `mosh` and not the `mobile-shell` alias, causing the state the fail. Update to the new name, which is also consistent with everyone else.
|
The upstream change is at Homebrew/homebrew-core#18636. r? @larsbergstrom or @edunham |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 30, 2017
…ergstrom Handle Homebrew renaming `mobile-shell` to `mosh` Homebrew left in an alias for `mobile-shell` so the `mosh` package actually installs correctly, but Salt's pkg.installed state then tries to verify the installation by checking the installed packages. That list only shows `mosh` and not the `mobile-shell` alias, causing the state the fail. Update to the new name, which is also consistent with everyone else. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/724) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedSep 29, 2017
•
edited by larsbergstrom
Homebrew left in an alias for
mobile-shellso themoshpackageactually installs correctly, but Salt's pkg.installed state then tries
to verify the installation by checking the installed packages.
That list only shows
moshand not themobile-shellalias,causing the state the fail.
Update to the new name, which is also consistent with everyone else.
This change is