Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @pepyakin as a bindgen reviewer #727

Merged
merged 1 commit into from Oct 2, 2017
Merged

Add @pepyakin as a bindgen reviewer #727

merged 1 commit into from Oct 2, 2017

Conversation

@fitzgen
Copy link
Member

fitzgen commented Oct 2, 2017

πŸŽ‰πŸŽ‰πŸŽ‰

r? @emilio


This change is Reviewable

πŸŽ‰πŸŽ‰πŸŽ‰
@emilio
Copy link
Member

emilio commented Oct 2, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2017

πŸ“Œ Commit d94b1fe has been approved by emilio

@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2017

βŒ› Testing commit d94b1fe with merge df07d3a...

bors-servo added a commit that referenced this pull request Oct 2, 2017
Add @pepyakin as a bindgen reviewer

πŸŽ‰πŸŽ‰πŸŽ‰

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/727)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2017

πŸ’” Test failed - status-travis

@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2017

β˜€οΈ Test successful - status-travis
Approved by: emilio
Pushing df07d3a to master...

@bors-servo bors-servo merged commit d94b1fe into master Oct 2, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@fitzgen
Copy link
Member Author

fitzgen commented Oct 5, 2017

This doesn't seem to have been enough to let @pepyakin r+ things... anyone know what else needs to happen?

rust-lang/rust-bindgen#1061 (comment)

@fitzgen fitzgen deleted the fitzgen-patch-1 branch Oct 5, 2017
@edunham
Copy link
Contributor

edunham commented Oct 5, 2017

Presently highstating buildmaster to actually apply these changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.