Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to Vagrant 2 for `salt_call_args` #729
Merged
Conversation
Vagrant 2.0.0 adds support for a new `salt_call_args` option. We use this option to specify some additional arguments for Vagrant. Previously, we used a hack to pass these options via the `minion_id` parameter, but that hack stopped working as of Vagrant 1.8.3
|
See the changelog at https://github.com/hashicorp/vagrant/blob/master/CHANGELOG.md#200-september-7-2017. r? @larsbergstrom or @edunham |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 12, 2017
Upgrade to Vagrant 2 for `salt_call_args` Vagrant 2.0.0 adds support for a new `salt_call_args` option. We use this option to specify some additional arguments for Vagrant. Previously, we used a hack to pass these options via the `minion_id` parameter, but that hack stopped working as of Vagrant 1.8.3 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/729) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Oct 13, 2017
Upgrade to Vagrant 2 for `salt_call_args` Vagrant 2.0.0 adds support for a new `salt_call_args` option. We use this option to specify some additional arguments for Vagrant. Previously, we used a hack to pass these options via the `minion_id` parameter, but that hack stopped working as of Vagrant 1.8.3 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/729) <!-- Reviewable:end -->
|
|
|
|
|
This doesn't need to be deployed in any way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedOct 4, 2017
•
edited by larsbergstrom
Vagrant 2.0.0 adds support for a new
salt_call_argsoption.We use this option to specify some additional arguments for Vagrant.
Previously, we used a hack to pass these options via the
minion_idparameter, but that hack stopped working as of Vagrant 1.8.3
This change is