Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable homu for servo/gecko-media. #736

Merged
merged 1 commit into from Oct 18, 2017
Merged

Conversation

@metajack
Copy link
Contributor

metajack commented Oct 17, 2017

This change is Reviewable

@Manishearth
Copy link
Member

Manishearth commented Oct 17, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

📌 Commit fb55f3e has been approved by Manishearth

@nox
Copy link
Member

nox commented Oct 17, 2017

@highfive highfive assigned Manishearth and unassigned aneeshusa Oct 17, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

💡 This pull request was already approved, no need to approve it again.

@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

📌 Commit fb55f3e has been approved by nox

@highfive highfive assigned nox and unassigned Manishearth Oct 17, 2017
bors-servo added a commit that referenced this pull request Oct 17, 2017
Enable homu for servo/gecko-media.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/736)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

Testing commit fb55f3e with merge 6203bef...

@highfive highfive assigned Manishearth and unassigned nox Oct 17, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 18, 2017

☀️ Test successful - status-travis
Approved by: nox
Pushing 6203bef to master...

@bors-servo bors-servo merged commit fb55f3e into servo:master Oct 18, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@metajack metajack deleted the metajack:homu-gecko-media branch Oct 18, 2017
@aneeshusa
Copy link
Member

aneeshusa commented Oct 18, 2017

@metajack deployed this and it's working, so removing the S-needs-deploy label. Friendly reminder to remove the label after deploying something :)

@metajack
Copy link
Contributor Author

metajack commented Oct 18, 2017

@aneeshusa sorry about that. I didn't know about that label :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.