Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for changing the user #741

Merged
merged 1 commit into from Nov 3, 2017
Merged

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Oct 25, 2017

r? @aneeshusa


This change is Reviewable

@@ -80,6 +80,8 @@ Note that your prompt will change once you're inside a VM.

* `vagrant@vagrant-ubuntu-trusty-64$ sudo apt-get -y install cowsay; cowsay 'servo-saltfs ❤ Vagrant'`:
Run commands in the VM
* `vagrant@vagrant-ubuntu-trusty-64$ sudo su - servo`:
Change to user Servo

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Oct 26, 2017

Member

nit: Servo -> servo

@aneeshusa
Copy link
Member

aneeshusa commented Oct 26, 2017

r=me with the nit fixed.
Friendly reminder to please not @-mention in commit messages or PR descriptions :)

@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Oct 28, 2017

Sure, will do - I thought that was just for servo due to the weird mirroring process gecko has!

@larsbergstrom larsbergstrom force-pushed the larsbergstrom-patch-1 branch from aee649d to 66bdc5f Oct 28, 2017
@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Oct 28, 2017

Updated - r? @aneeshusa

@jdm
Copy link
Member

jdm commented Oct 28, 2017

Yeah, the username thing only matters for servo/servo PRs.

@jdm
Copy link
Member

jdm commented Nov 3, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2017

📌 Commit 66bdc5f has been approved by jdm

@highfive highfive assigned jdm and unassigned aneeshusa Nov 3, 2017
bors-servo added a commit that referenced this pull request Nov 3, 2017
Add instructions for changing the user

r? @aneeshusa

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/741)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2017

Testing commit 66bdc5f with merge a5079d1...

@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2017

☀️ Test successful - status-travis
Approved by: jdm
Pushing a5079d1 to master...

@bors-servo bors-servo merged commit 66bdc5f into master Nov 3, 2017
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
homu Test successful
Details
@jdm jdm removed the S-needs-deploy label Nov 6, 2017
@SimonSapin SimonSapin deleted the larsbergstrom-patch-1 branch Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.