Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix failure tracker #742
Fix failure tracker #742
Conversation
… changes.
|
This fixes a long-time issue with the intermittent-tracker where we never actually could update the installed package on the server. This also makes the new intermittent failure tracker server start up successfully; I hadn't tried it in python3 before. |
|
r? @metajack |
|
Seems reasonable, mostly a few questions. |
| @@ -9,13 +9,16 @@ intermittent-failure-tracker: | |||
| - venv_bin: virtualenv-3.5 | |||
| - python: python3 | |||
| - system_site_packages: False | |||
| - pip_pkgs: | |||
| - setuptools-git | |||
This comment has been minimized.
This comment has been minimized.
| @@ -1,5 +1,5 @@ | |||
| {% | |||
| set tracker = { | |||
| 'rev': '37ef73bb0059e0555a903e758dae8006c46a9916' | |||
| 'rev': 'f2f3825b6b026b54769a995ae8a526b2d81ee5fd' | |||
This comment has been minimized.
This comment has been minimized.
aneeshusa
Oct 26, 2017
Member
It would be nice to publish all these packages to PyPI as well, as our Salt version does better with that than git installs.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aneeshusa
Oct 26, 2017
Member
#593 is what I'm aware of; this may have been fixed or improved since then but at least in our old Salt the git installs seem less well supported.
This comment has been minimized.
This comment has been minimized.
jdm
Oct 26, 2017
Author
Member
Per my latest comment in that issue, a2934d0 is all that is necessary. I would rather not go through the effort of publishing these packages.
This comment has been minimized.
This comment has been minimized.
aneeshusa
Oct 26, 2017
Member
Thanks for updating that issue, since it seems to be working then git dependencies are fine by me.
| @@ -37,6 +40,12 @@ intermittent-failure-tracker: | |||
| - group: servo | |||
| - mode: 644 | |||
| /home/servo/intermittent-failure-tracker/intermittent_errors.json: | |||
This comment has been minimized.
This comment has been minimized.
aneeshusa
Oct 26, 2017
Member
Why do we need to create this file ourselves? Seems like something the package should create on-demand.
This comment has been minimized.
This comment has been minimized.
jdm
Oct 26, 2017
Author
Member
The current working directory is not owned by the user that is running the server, so it can't.
|
r? @metajack |
|
@bors-servo r+ |
|
|
Fix failure tracker <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/742) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
Fix failure tracker <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/742) <!-- Reviewable:end -->
|
|
jdm commentedOct 25, 2017
•
edited by larsbergstrom
This change is