Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install rustup on workers. #758

Merged
merged 1 commit into from Nov 29, 2017
Merged

Install rustup on workers. #758

merged 1 commit into from Nov 29, 2017
+10 −0

Conversation

@jdm
Copy link
Member

jdm commented Nov 28, 2017 •
edited by larsbergstrom

Fixes #757.

This change is Reviewable
@SimonSapin
SimonSapin reviewed Nov 28, 2017
View changes
servo-build-dependencies/init.sls
sh -s -- --default-toolchain none -y
- runas: servo
- creates:
- {{ common.servo_home }}/.rustup

This comment has been minimized.

Sign in to view
Copy link
@SimonSapin

SimonSapin Nov 28, 2017

Member

I think it also creates .cargo, and creates-or-modifies .profile to add .cargo/bin to $PATH.
@jdm
Install rustup on workers.
Loading status checks…
a6c7094
@jdm jdm force-pushed the jdm:rustup branch from 161dcca to a6c7094 Nov 28, 2017
@SimonSapin
Copy link
Member

SimonSapin commented Nov 28, 2017

One Travis job failed with what looked like an intermittent network error. I’ve restarted it.
@SimonSapin
Copy link
Member

SimonSapin commented Nov 28, 2017

The error now looks different, but is apparently still network related:

          ID: ffmpeg-ppa
    Function: pkgrepo.managed
      Result: False
     Comment: Failed to configure repo 'ffmpeg-ppa': Error: key retrieval failed: Executing: /tmp/tmp.sEdqE4Fw3v/gpg.1.sh --keyserver
              keyserver.ubuntu.com
              --logger-fd
              1
              --recv-keys
              4AB0F789CBA31744CC7DA76A8CF63AD3F06FC659
              gpgkeys: key 4AB0F789CBA31744CC7DA76A8CF63AD3F06FC659 can't be retrieved
              gpg: requesting key F06FC659 from hkp server keyserver.ubuntu.com
              gpg: no valid OpenPGP data found.
              gpg: Total number processed: 0
              gpg: keyserver communications error: keyserver helper general error
              gpg: keyserver communications error: unknown pubkey algorithm
              gpg: keyserver receive failed: unknown pubkey algorithm
     Started: 15:50:28.311843
    Duration: 20645.952 ms
     Changes:
@jdm jdm force-pushed the jdm:rustup branch from 23e0537 to a6c7094 Nov 28, 2017
@SimonSapin
Copy link
Member

SimonSapin commented Nov 29, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 29, 2017

📌 Commit a6c7094 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned aneeshusa Nov 29, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Nov 29, 2017

⌛ Testing commit a6c7094 with merge f6a202a...
bors-servo added a commit that referenced this pull request Nov 29, 2017
@bors-servo
Auto merge of #758 - jdm:rustup, r=SimonSapin
Loading status checks…
f6a202a 
Install rustup on workers.

Fixes #757.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/758)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 29, 2017

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing f6a202a to master...
@bors-servo bors-servo merged commit a6c7094 into servo:master Nov 29, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm removed the S-needs-deploy label Nov 29, 2017
SimonSapin added a commit that referenced this pull request Dec 13, 2017
@SimonSapin
Add rustup-installed binaries to $PATH
Loading status checks…
263fa24 
This is a continuation of #758
@SimonSapin SimonSapin mentioned this pull request Dec 13, 2017
Merged
bors-servo added a commit that referenced this pull request Dec 13, 2017
@bors-servo
Auto merge of #762 - servo:rustup, r=aneeshusa
Loading status checks…
a92a5fc 
Add rustup-installed binaries to $PATH

This is a continuation of #758

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/762)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 13, 2017
@bors-servo
Auto merge of #762 - servo:rustup, r=aneeshusa
Loading status checks…
6baed4f 
Add rustup-installed binaries to $PATH

This is a continuation of #758

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/762)
<!-- Reviewable:end -->
@SimonSapin
SimonSapin reviewed Jan 8, 2018
View changes
servo-build-dependencies/init.sls
include:
- python
servo-dependencies:
cmd.run:
- name: |
curl https://sh.rustup.rs -sSf |

This comment has been minimized.

Sign in to view
Copy link
@SimonSapin

SimonSapin Jan 8, 2018 •
edited

Member

This only works on Unix-like systems. On Windows we need to (somehow?) download https://win.rustup.rs/ as rustup-init.exe, then run rustup-init.exe -y --default-host x86_64-pc-windows-msvc --default-toolchain none.
This was referenced Jan 9, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin

Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @SimonSapin @bors-servo @aneeshusa @highfive
You can’t perform that action at this time.