Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInstall rustup on workers. #758
Merged
+10
−0
Conversation
| sh -s -- --default-toolchain none -y | ||
| - runas: servo | ||
| - creates: | ||
| - {{ common.servo_home }}/.rustup |
This comment has been minimized.
This comment has been minimized.
SimonSapin
Nov 28, 2017
Member
I think it also creates .cargo, and creates-or-modifies .profile to add .cargo/bin to $PATH.
|
One Travis job failed with what looked like an intermittent network error. I’ve restarted it. |
|
The error now looks different, but is apparently still network related: |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 29, 2017
Install rustup on workers. Fixes #757. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/758) <!-- Reviewable:end -->
|
|
SimonSapin
added a commit
that referenced
this pull request
Dec 13, 2017
bors-servo
added a commit
that referenced
this pull request
Dec 13, 2017
Add rustup-installed binaries to $PATH This is a continuation of #758 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/762) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Dec 13, 2017
Add rustup-installed binaries to $PATH This is a continuation of #758 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/762) <!-- Reviewable:end -->
| include: | ||
| - python | ||
| servo-dependencies: | ||
| cmd.run: | ||
| - name: | | ||
| curl https://sh.rustup.rs -sSf | |
This comment has been minimized.
This comment has been minimized.
SimonSapin
Jan 8, 2018
•
Member
This only works on Unix-like systems. On Windows we need to (somehow?) download https://win.rustup.rs/ as rustup-init.exe, then run rustup-init.exe -y --default-host x86_64-pc-windows-msvc --default-toolchain none.
This was referenced Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedNov 28, 2017
•
edited by larsbergstrom
Fixes #757.
This change is