This repository was archived by the owner on Dec 16, 2024. It is now read-only.
Merged
Conversation
SimonSapin
reviewed
Nov 28, 2017
| sh -s -- --default-toolchain none -y | ||
| - runas: servo | ||
| - creates: | ||
| - {{ common.servo_home }}/.rustup |
Member
There was a problem hiding this comment.
I think it also creates .cargo, and creates-or-modifies .profile to add .cargo/bin to $PATH.
Member
|
One Travis job failed with what looked like an intermittent network error. I’ve restarted it. |
Member
|
The error now looks different, but is apparently still network related: |
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit a6c7094 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Nov 29, 2017
Install rustup on workers. Fixes #757. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/758) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
SimonSapin
added a commit
that referenced
this pull request
Dec 13, 2017
This is a continuation of #758
bors-servo
pushed a commit
that referenced
this pull request
Dec 13, 2017
Add rustup-installed binaries to $PATH This is a continuation of #758 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/762) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Dec 13, 2017
Add rustup-installed binaries to $PATH This is a continuation of #758 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/762) <!-- Reviewable:end -->
SimonSapin
reviewed
Jan 8, 2018
| servo-dependencies: | ||
| cmd.run: | ||
| - name: | | ||
| curl https://sh.rustup.rs -sSf | |
Member
There was a problem hiding this comment.
This only works on Unix-like systems. On Windows we need to (somehow?) download https://win.rustup.rs/ as rustup-init.exe, then run rustup-init.exe -y --default-host x86_64-pc-windows-msvc --default-toolchain none.
This was referenced Jan 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #757.
This change is