Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Comments

Install rustup on workers.#758

Merged
bors-servo merged 1 commit intoservo:masterfrom
jdm:rustup
Nov 29, 2017
Merged

Install rustup on workers.#758
bors-servo merged 1 commit intoservo:masterfrom
jdm:rustup

Conversation

@jdm
Copy link
Member

@jdm jdm commented Nov 28, 2017

Fixes #757.


This change is Reviewable

sh -s -- --default-toolchain none -y
- runas: servo
- creates:
- {{ common.servo_home }}/.rustup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it also creates .cargo, and creates-or-modifies .profile to add .cargo/bin to $PATH.

@SimonSapin
Copy link
Member

One Travis job failed with what looked like an intermittent network error. I’ve restarted it.

@SimonSapin
Copy link
Member

The error now looks different, but is apparently still network related:

          ID: ffmpeg-ppa
    Function: pkgrepo.managed
      Result: False
     Comment: Failed to configure repo 'ffmpeg-ppa': Error: key retrieval failed: Executing: /tmp/tmp.sEdqE4Fw3v/gpg.1.sh --keyserver
              keyserver.ubuntu.com
              --logger-fd
              1
              --recv-keys
              4AB0F789CBA31744CC7DA76A8CF63AD3F06FC659
              gpgkeys: key 4AB0F789CBA31744CC7DA76A8CF63AD3F06FC659 can't be retrieved
              gpg: requesting key F06FC659 from hkp server keyserver.ubuntu.com
              gpg: no valid OpenPGP data found.
              gpg: Total number processed: 0
              gpg: keyserver communications error: keyserver helper general error
              gpg: keyserver communications error: unknown pubkey algorithm
              gpg: keyserver receive failed: unknown pubkey algorithm
     Started: 15:50:28.311843
    Duration: 20645.952 ms
     Changes:   

@SimonSapin
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit a6c7094 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit a6c7094 with merge f6a202a...

bors-servo pushed a commit that referenced this pull request Nov 29, 2017
Install rustup on workers.

Fixes #757.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/758)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing f6a202a to master...

@bors-servo bors-servo merged commit a6c7094 into servo:master Nov 29, 2017
SimonSapin added a commit that referenced this pull request Dec 13, 2017
bors-servo pushed a commit that referenced this pull request Dec 13, 2017
Add rustup-installed binaries to $PATH

This is a continuation of #758

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/762)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request Dec 13, 2017
Add rustup-installed binaries to $PATH

This is a continuation of #758

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/762)
<!-- Reviewable:end -->
servo-dependencies:
cmd.run:
- name: |
curl https://sh.rustup.rs -sSf |
Copy link
Member

@SimonSapin SimonSapin Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works on Unix-like systems. On Windows we need to (somehow?) download https://win.rustup.rs/ as rustup-init.exe, then run rustup-init.exe -y --default-host x86_64-pc-windows-msvc --default-toolchain none.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants