New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS credentials to buildbot aws steps. #760
Conversation
r? @jdm |
@@ -216,6 +216,12 @@ def make_step(self, command, env): | |||
step_kwargs['logEnviron'] = False | |||
step_env += envs.upload_nightly | |||
|
|||
# Provide credentials where necessary | |||
if arg == 'aws': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: elif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Fixed.
@bors-servo: r+ |
📌 Commit 60f1ca9 has been approved by |
Add AWS credentials to buildbot aws steps. Add the AWS credentials to any buildbot steps running `aws`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/760) <!-- Reviewable:end -->
☀️ Test successful - status-travis |
Add the AWS credentials to any buildbot steps running
aws
.This change is