Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rustup update when specific version not present. #761

Closed
wants to merge 1 commit into from

Conversation

@jdm
Copy link
Member

jdm commented Dec 8, 2017

This PR causes us to update to the most recent release of rustup, as a result.


This change is Reviewable

@jdm
Copy link
Member Author

jdm commented Dec 8, 2017

@highfive highfive assigned metajack and unassigned aneeshusa Dec 8, 2017
@aneeshusa
Copy link
Member

aneeshusa commented Dec 13, 2017

This current solution will cause new machines to fail to bootstrap if rustup publishes a newer version than 1.7.0.
I would want to have versioned-locked download URLs for reproducibility.
The long term goal here is versioned uploads of rustup itself, published by the rustup.rs repo (either S3 or GH releases).
In the meantime, we can manually mirror selected versions to a servo-controlled S3 bucket (we have a couple of them).
I would prefer to download rustup itself directly if it is a static binary on all platforms (similar to sccache), but if that is not possible it would also be acceptable to have versioned URLs for the rustup installer.

@SimonSapin
Copy link
Member

SimonSapin commented Dec 17, 2017

I don’t think we should be in the business of hosting rustup binaries. We can parse the output of rustup --version to extract a tuple of integers, and check for a minimum version instead of an exact one.

@SimonSapin
Copy link
Member

SimonSapin commented Dec 17, 2017

Something like…

-    - unless: rustup --version | grep '{{ rustup.version }}'
+    - unless: rustup --version |  python -c 'import sys, re; [int(i) for i in re.match("rustup (\d+).(\d+).(\d+) ", sys.stdin.read()).groups()] >= [1, 7, 0] or sys.exit(1)'
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2017

The latest upstream changes (presumably #767) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm jdm closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.