Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added steps to gzip compress the logs (for servo issue #6399) #77

Merged
merged 1 commit into from Jun 24, 2015

Conversation

@wafflespeanut
Copy link
Member

wafflespeanut commented Jun 24, 2015

@larsbergstrom What do you think? I also wonder whether it needs to be done for release builds too (?)

@wafflespeanut wafflespeanut changed the title Added steps to gzip compress the logs for #6399... Added steps to gzip compress the logs (for servo issue #6399) Jun 24, 2015
@metajack
Copy link
Contributor

metajack commented Jun 24, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Jun 24, 2015

📌 Commit ab13ecd has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented Jun 24, 2015

Testing commit ab13ecd with merge 3e3d662...

bors-servo pushed a commit that referenced this pull request Jun 24, 2015
Added steps to gzip compress the logs (for servo issue #6399)

@larsbergstrom What do you think? I also wonder whether it needs to be done for release builds too (?)
@bors-servo
Copy link
Contributor

bors-servo commented Jun 24, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit ab13ecd into servo:master Jun 24, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@wafflespeanut wafflespeanut deleted the wafflespeanut:compress_wpt_log branch Jun 24, 2015
@wafflespeanut
Copy link
Member Author

wafflespeanut commented Jun 24, 2015

@metajack Thanks for your review. Now, would you be kind and close the issue? :)

@metajack
Copy link
Contributor

metajack commented Jun 24, 2015

I'll close the bug when the fix gets deployed. I'm waiting for buildbot idle to deploy it.

@wafflespeanut
Copy link
Member Author

wafflespeanut commented Jun 24, 2015

@metajack Alright, thanks. Regarding the PR, don't we need to add steps to decompress the logs later or something? I mean, we do need the logs, right?

Manishearth pushed a commit that referenced this pull request Mar 9, 2016
Include OAuth callback in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.