Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd taskcluster status checking to webrender #776
Conversation
|
Looks good to me. Assuming that @edunham is on PTO today can we land this now and do a post commit review tomorrow? |
|
@bors-servo r+ |
|
|
Add taskcluster status checking to webrender r? @edunham See below for an example of status output for an auto-push with Taskcluster test run: https://api.github.com/repos/servo/webrender/commits/e582ec8/status cc @jrmuizel @glennw @aneeshusa <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/776) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
Add taskcluster status checking to webrender r? @edunham See below for an example of status output for an auto-push with Taskcluster test run: https://api.github.com/repos/servo/webrender/commits/e582ec8/status cc @jrmuizel @glennw @aneeshusa <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/776) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
Add taskcluster status checking to webrender r? @edunham See below for an example of status output for an auto-push with Taskcluster test run: https://api.github.com/repos/servo/webrender/commits/e582ec8/status cc @jrmuizel @glennw @aneeshusa <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/776) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
Add taskcluster status checking to webrender r? @edunham See below for an example of status output for an auto-push with Taskcluster test run: https://api.github.com/repos/servo/webrender/commits/e582ec8/status cc @jrmuizel @glennw @aneeshusa <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/776) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
@bors-servo retry |
Add taskcluster status checking to webrender r? @edunham See below for an example of status output for an auto-push with Taskcluster test run: https://api.github.com/repos/servo/webrender/commits/e582ec8/status cc @jrmuizel @glennw @aneeshusa <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/776) <!-- Reviewable:end -->
|
@jdm @larsbergstrom Is this needed? TC + WR + bors seem to be working happily now - does that add something extra? |
|
I believe this change makes bors actually gate on TC. Without it, the merge could happen as soon as appveyor finishes build successfully. |
|
@glennw I did yolo-ops on the server. If we don't get this fix landed, the next time somebody makes a homu change and does a highstate, you'll lose WR gating on TC. |
|
|
|
@bors-servo retry |
Add taskcluster status checking to webrender r? @edunham See below for an example of status output for an auto-push with Taskcluster test run: https://api.github.com/repos/servo/webrender/commits/e582ec8/status cc @jrmuizel @glennw @aneeshusa <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/776) <!-- Reviewable:end -->
|
I'm very tempted to just merge this. We have a pass on the PR itself (https://travis-ci.org/servo/saltfs/builds/329179115?utm_source=github_status&utm_medium=notification) but the combination of mac and salt server instability is breaking the test runs one after another. |
|
I think it's worth pushing the button. |
larsbergstrom
force-pushed the
larsbergstrom:add_taskcluster_webrender
branch
from
15cccbf
to
d177fb1
|
Ugh, needed a rebase and now have to wait for status checks. lol :-) |
|
@bors-servo r=jdm |
|
|
Add taskcluster status checking to webrender r? @edunham See below for an example of status output for an auto-push with Taskcluster test run: https://api.github.com/repos/servo/webrender/commits/e582ec8/status cc @jrmuizel @glennw @aneeshusa <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/776) <!-- Reviewable:end -->
|
|
|
Deployed. |
larsbergstrom commentedJan 15, 2018
•
edited
r? @edunham
See below for an example of status output for an auto-push with Taskcluster test run:
https://api.github.com/repos/servo/webrender/commits/e582ec8/status
cc @jrmuizel @glennw @aneeshusa
This change is