Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImport module for missing user requirement. #782
Merged
Conversation
|
r? @aneeshusa |
|
@bors-servo r+ Lines 4 to 7 in f50214b However, this is still an improvement in the case that someone uses state.sls to selectively run the buildbot.slave SLS, so it's good to have (helps with #496).
|
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 27, 2018
Import module for missing user requirement. This fixes a longstanding problem when highstating on servo-mac4, since the user requirement is defined in common/init.sls. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/782) <!-- Reviewable:end -->
|
|
|
Seemed to failed around starting the buildbot-slave service on OS X, so possibly related, but I think this is a Travis CI flake. |
bors-servo
added a commit
that referenced
this pull request
Jan 27, 2018
Import module for missing user requirement. This fixes a longstanding problem when highstating on servo-mac4, since the user requirement is defined in common/init.sls. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/782) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJan 25, 2018
•
edited by larsbergstrom
This fixes a longstanding problem when highstating on servo-mac4, since the user requirement is defined in common/init.sls.
This change is