Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upProvide credentials to nightly WPT sync job #783
Conversation
|
r? @asajeffrey |
| @@ -152,4 +153,5 @@ def without(self, to_unset): | |||
| 'AWS_ACCESS_KEY_ID': S3_UPLOAD_ACCESS_KEY_ID, | |||
| 'AWS_SECRET_ACCESS_KEY': S3_UPLOAD_SECRET_ACCESS_KEY, | |||
| 'GITHUB_HOMEBREW_TOKEN': GITHUB_HOMEBREW_TOKEN, | |||
| 'WPT_SYNC_TOKEN': WPT_SYNC_PR_CREATION_TOKEN, | |||
This comment has been minimized.
This comment has been minimized.
aneeshusa
Jan 27, 2018
Member
Why are we putting this in the upload_nightly environment? It sounds like this is being run as a separate step, so we should use a separate environment (e.g. I find it unlikely this needs AWS access), and use the environment combining feature with + if necessary.
This comment has been minimized.
This comment has been minimized.
| @@ -38,6 +38,7 @@ deploy-{{ common.servo_home }}/buildbot/master: | |||
| - context: | |||
| common: {{ common }} | |||
| buildbot_credentials: {{ pillar['buildbot']['credentials'] }} | |||
| wpt_sync_credentials: {{ pillar['wpt-sync'] }} | |||
This comment has been minimized.
This comment has been minimized.
aneeshusa
Jan 27, 2018
Member
I'd prefer if these credentials got moved under buildbot:credentials so this line is not needed. The test credential would be removed from the .travis/test_pillars/wpt-sync.sls file and moved into the .travis/test_pillars/buildbot/master.sls.
This comment has been minimized.
This comment has been minimized.
jdm
Jan 27, 2018
Author
Member
It's also used by https://github.com/servo/saltfs/blob/master/upstream-wpt-webhook/files/config.json#L2 so it won't actually be removed.
This comment has been minimized.
This comment has been minimized.
aneeshusa
Jan 27, 2018
Member
I didn't realize that, keeping the current setup makes sense to me then.
|
Thanks! |
|
|
Provide credentials to nightly WPT sync job This will give us more useful information by actually creating a PR with the results of syncing with upstream. We can choose to disregard it without any issue. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/783) <!-- Reviewable:end -->
|
|
|
Looks like there is a lint error: |
highfive
added
S-awaiting-review
and removed
S-tests-failed
S-needs-code-changes
labels
|
@bors-servo r=aneeshusa |
|
|
Provide credentials to nightly WPT sync job This will give us more useful information by actually creating a PR with the results of syncing with upstream. We can choose to disregard it without any issue. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/783) <!-- Reviewable:end -->
|
|
jdm commentedJan 26, 2018
•
edited by larsbergstrom
This will give us more useful information by actually creating a PR with the results of syncing with upstream. We can choose to disregard it without any issue.
This change is