Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows minion targeting #785

Merged
merged 1 commit into from Jan 28, 2018

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Jan 28, 2018

Use the correct type of targeting so the Windows minions
actually have states to run during highstates.

Fixes #766.


This change is Reviewable

Use the correct type of targeting so the Windows minions
actually have states to run during highstates.
@aneeshusa
Copy link
Member Author

aneeshusa commented Jan 28, 2018

I want to get this in to make it easier to apply and test sccache changes.
r? @larsbergstrom or @jdm

@jdm
Copy link
Member

jdm commented Jan 28, 2018

@bors-servo r+
Geeze. I feel silly for missing that.

@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2018

📌 Commit 30ba649 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2018

Testing commit 30ba649 with merge ee0a6fb...

bors-servo added a commit that referenced this pull request Jan 28, 2018
Fix Windows minion targeting

Use the correct type of targeting so the Windows minions
actually have states to run during highstates.

Fixes #766.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/785)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing ee0a6fb to master...

@bors-servo bors-servo merged commit 30ba649 into servo:master Jan 28, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm removed the S-needs-deploy label Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.