Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my SSH key #795

Merged
merged 1 commit into from Feb 7, 2018
Merged

Add my SSH key #795

merged 1 commit into from Feb 7, 2018

Conversation

@jonleighton
Copy link
Contributor

jonleighton commented Feb 7, 2018

In servo/servo#19928 @metajack suggested that I could use one of the builders to work on Mac-specific code and @jdm requested I submit my key in a PR here.


This change is Reviewable

In servo/servo#19928 @metajack suggested that I could use one of the builders to work on Mac-specific code and @jdm requested I submit my key in a PR here.
@jdm
Copy link
Member

jdm commented Feb 7, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

📌 Commit 82848f9 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

Testing commit 82848f9 with merge 74b136c...

bors-servo added a commit that referenced this pull request Feb 7, 2018
Add my SSH key

In servo/servo#19928 @metajack suggested that I could use one of the builders to work on Mac-specific code and @jdm requested I submit my key in a PR here.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/795)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 7, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing 74b136c to master...

@bors-servo bors-servo merged commit 82848f9 into servo:master Feb 7, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm
Copy link
Member

jdm commented Feb 7, 2018

Oops, I just noticed that we need an entry in https://github.com/servo/saltfs/blob/master/admin/map.jinja as well per

### Gaining SSH Access
.

jonleighton added a commit to jonleighton/saltfs that referenced this pull request Feb 7, 2018
bors-servo added a commit that referenced this pull request Feb 7, 2018
Add myself to ssh users

See #795 (comment)

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/796)
<!-- Reviewable:end -->
@jdm jdm removed the S-needs-deploy label Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.