Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS for build.servo.org #818

Merged
merged 4 commits into from May 17, 2018
Merged

Add HTTPS for build.servo.org #818

merged 4 commits into from May 17, 2018

Conversation

@jdm
Copy link
Member

jdm commented Mar 14, 2018

This is yolo-deployed so it can be observed to work: http://build.servo.org/grid should load https://build.servo.org/grid.


This change is Reviewable

@jdm jdm force-pushed the jdm:buildcert branch from 3e96214 to a489081 Mar 14, 2018
@jdm
Copy link
Member Author

jdm commented Mar 14, 2018

I originally had an HTTPS redirect for any HTTP URL, but that broke our tools like ./mach filter-intermittent that became confused by a 307 response. We'll need to do this in two stages - first, turn on HTTPS. Once we've migrated everything to use HTTPS URLs, we can add the HTTP->HTTPS redirect. This should be ready to merge and deploy in its current state.

@aneeshusa
Copy link
Member

aneeshusa commented Mar 15, 2018

Thanks for working on this! I'd also love to see more software support 307s - if you have an error message handy I'd be interested in seeing what we can do about that.

cron.present:
- identifier: build-cert-renew
- user: root
- minute: 0

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Mar 15, 2018

Member

In the interest of being a good internet citizen, let's not use midnight directly but a more "random" time as the base - I'm sure they already get way too many requests right at midnight. Additionally, we can use sleep to add some more jitter: https://stackoverflow.com/questions/9049460/cron-jobs-and-random-times-within-given-hours/16289693#16289693 for example.

- user: root
- minute: 0
- hour: 0
- daymonth: 1

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Mar 15, 2018

Member

Instead of running once a month, it would be nice to run once a week (ish) so we can catch problems faster. Also, we should figure out a story for getting notifications of failed jobs.

@jdm
Copy link
Member Author

jdm commented Mar 15, 2018

@jdm jdm force-pushed the jdm:buildcert branch from ded94cf to 9c60f7f Mar 19, 2018
@jdm
Copy link
Member Author

jdm commented Mar 19, 2018

I've addressed both comments. My best idea for notifying when the job fails is to file a github issue in this repository.

@edunham edunham dismissed aneeshusa’s stale review May 17, 2018

The requested changes have been completed.

@edunham
Copy link
Contributor

edunham commented May 17, 2018

Looks good to me. I agree that failures should report to somewhere, perhaps a GitHub issue, but I would rather not block landing this on setting that up.

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

📌 Commit 9c60f7f has been approved by edunham

@jdm
Copy link
Member Author

jdm commented May 17, 2018

I mean, the changes in this PR include filing a github issue when there's a failure, so... :)

@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

Testing commit 9c60f7f with merge cfdc53a...

bors-servo added a commit that referenced this pull request May 17, 2018
Add HTTPS for build.servo.org

This is yolo-deployed so it can be observed to work: http://build.servo.org/grid should load https://build.servo.org/grid.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/818)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2018

☀️ Test successful - status-travis
Approved by: edunham
Pushing cfdc53a to master...

@bors-servo bors-servo merged commit 9c60f7f into servo:master May 17, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.