Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd HTTPS for build.servo.org #818
Conversation
|
I originally had an HTTPS redirect for any HTTP URL, but that broke our tools like |
|
Thanks for working on this! I'd also love to see more software support |
| cron.present: | ||
| - identifier: build-cert-renew | ||
| - user: root | ||
| - minute: 0 |
This comment has been minimized.
This comment has been minimized.
aneeshusa
Mar 15, 2018
Member
In the interest of being a good internet citizen, let's not use midnight directly but a more "random" time as the base - I'm sure they already get way too many requests right at midnight. Additionally, we can use sleep to add some more jitter: https://stackoverflow.com/questions/9049460/cron-jobs-and-random-times-within-given-hours/16289693#16289693 for example.
| - user: root | ||
| - minute: 0 | ||
| - hour: 0 | ||
| - daymonth: 1 |
This comment has been minimized.
This comment has been minimized.
aneeshusa
Mar 15, 2018
Member
Instead of running once a month, it would be nice to run once a week (ish) so we can catch problems faster. Also, we should figure out a story for getting notifications of failed jobs.
|
I've addressed both comments. My best idea for notifying when the job fails is to file a github issue in this repository. |
|
Looks good to me. I agree that failures should report to somewhere, perhaps a GitHub issue, but I would rather not block landing this on setting that up. @bors-servo r+ |
|
|
|
I mean, the changes in this PR include filing a github issue when there's a failure, so... :) |
Add HTTPS for build.servo.org This is yolo-deployed so it can be observed to work: http://build.servo.org/grid should load https://build.servo.org/grid. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/818) <!-- Reviewable:end -->
|
|
jdm commentedMar 14, 2018
•
edited by larsbergstrom
This is yolo-deployed so it can be observed to work: http://build.servo.org/grid should load https://build.servo.org/grid.
This change is