Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove travis gating for webrender. #820
Closed
Conversation
Having the travis-ci gate enabled is causing several issues for the WR repo at the moment (mostly timeouts, but also complicating updating the Linux version used by the builders). This moves the WR reviewers to the main reviewers list. This does give those named reviewers extra repo privileges over what the previous configuration. I'm not sure if there's a better way to remove the WR gating while also keeping WR reviewer status. Fixes #803.
|
I have no idea what I'm doing here. Does this make sense? r? @larsbergstrom or @edunham or @jdm |
|
I'm trying another solution that will retain the reviewer status quo. |
|
#821 is a more future-friendly solution. |
|
Cunningham's Law in action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedMar 18, 2018
•
edited by larsbergstrom
Having the travis-ci gate enabled is causing several issues for
the WR repo at the moment (mostly timeouts, but also complicating
updating the Linux version used by the builders).
This moves the WR reviewers to the main reviewers list. This does
give those named reviewers extra repo privileges over what the
previous configuration. I'm not sure if there's a better way to
remove the WR gating while also keeping WR reviewer status.
Fixes #803.
This change is