Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run WPT against the release binaries, so that IPC servo can land #83

Merged
merged 1 commit into from Jul 24, 2015

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 24, 2015

r? @edunham

This change makes our web platform tests run against a release build of servo instead of debug, so that @pcwalton's IPC servo changes can land.

Review on Reviewable

@edunham
Copy link
Contributor

edunham commented Jul 24, 2015

Travis failed because a system package is not available to it; not your fault

Were we getting any benefit from running with --dev before?

@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Jul 24, 2015

@edunham The main benefit from --dev is that it tests for integer overflow. We plan to add it back so that we're testing both release (what we actually ship) and dev (the only way to get the overflow checking) once a Cargo feature lands that allows us to compile just some critical libraries in release during a dev build so that we aren't so slow we hit all the timeouts.

@edunham
Copy link
Contributor

edunham commented Jul 24, 2015

r+ thanks for the explanation! I'll trust your judgement on whether adding it back needs to be captured in an issue or not :)

@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Jul 24, 2015

Will do, but in the main Servo repo! I'll hit the big "merge" button since Travis is borken :-(

Thanks!

larsbergstrom added a commit that referenced this pull request Jul 24, 2015
Run WPT against the release binaries, so that IPC servo can land
@larsbergstrom larsbergstrom merged commit 9b61f78 into servo:master Jul 24, 2015
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.