Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIgnore installed copies of pip dependencies. #830
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 3, 2018
Ignore installed copies of pip dependencies. For reasons that are unclear to me, pip is suddenly complaining on TravisCI's macOS builders when the version of dependencies that we are trying to install already exist. These changes make that problem disappear so we can make other changes to salt. Fixes #829. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/830) <!-- Reviewable:end -->
|
|
edunham
added a commit
to edunham/saltfs
that referenced
this pull request
May 14, 2018
Lack of this change breaks macs but presence of this change breaks Linux.
bors-servo
added a commit
that referenced
this pull request
May 14, 2018
Apply #830 only to Macs Lack of this change breaks macs but presence of this change breaks Linux. cc servo/servo#20774 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/839) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMay 3, 2018
•
edited by larsbergstrom
For reasons that are unclear to me, pip is suddenly complaining on TravisCI's macOS builders when the version of dependencies that we are trying to install already exist. These changes make that problem disappear so we can make other changes to salt. Fixes #829.
This change is