Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRequire v4.0 of LLVM and friends #841
Merged
Conversation
|
Besides applying to a builder that's taken out of rotation, another way to test this might be to try to build a docker image (see docs/docker.md) and build servo in there; my memory is a bit fuzzy but IIRC the docker images can build servo, but can't quite run some of the tests (e.g. reftests that need xvfb). |
|
I applied these changes, and ran vagrant locally. With these changes |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 25, 2018
Require v4.0 of LLVM and friends Bindgen needs LLVM 3.9 or higher. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/841) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedMay 24, 2018
•
edited by larsbergstrom
Bindgen needs LLVM 3.9 or higher.
This change is