Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added libc6-dev-i386 build dependency for android #844

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented May 29, 2018

Fixes a build error for linux cross-compiles to android: when using bindgen to build the mozjs_sys crate:

/usr/include/x86_64-linux-gnu/gnu/stubs.h:7:11: fatal error: 'gnu/stubs-32.h' file not found
/usr/include/x86_64-linux-gnu/gnu/stubs.h:7:11: fatal error: 'gnu/stubs-32.h' file not found, err: true

This change is Reviewable

@asajeffrey
Copy link
Member Author

asajeffrey commented May 29, 2018

r? @jdm

@jdm
Copy link
Member

jdm commented May 29, 2018

@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2018

📌 Commit 7076387 has been approved by jdm

bors-servo added a commit that referenced this pull request May 29, 2018
…ndency, r=jdm

Added libc6-dev-i386 build dependency for android

Fixes a build error for linux cross-compiles to android: when using bindgen to build the mozjs_sys crate:
```
/usr/include/x86_64-linux-gnu/gnu/stubs.h:7:11: fatal error: 'gnu/stubs-32.h' file not found
/usr/include/x86_64-linux-gnu/gnu/stubs.h:7:11: fatal error: 'gnu/stubs-32.h' file not found, err: true
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/844)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2018

Testing commit 7076387 with merge 9003650...

@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing 9003650 to master...

@bors-servo bors-servo merged commit 7076387 into servo:master May 29, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
homu Test successful
Details
@jdm jdm removed the S-needs-deploy label May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.