Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install a systemd service file, not upstart, on Ubuntu 16.04 #853

Merged
merged 2 commits into from Jul 12, 2018
Merged

Install a systemd service file, not upstart, on Ubuntu 16.04 #853

merged 2 commits into from Jul 12, 2018

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jul 12, 2018 •
edited

Follow up to #852 (comment)

This change is Reviewable
@nox
Copy link
Member

nox commented Jul 12, 2018

r=me but it needs a rebase.
SimonSapin added 2 commits Jul 12, 2018
@SimonSapin
Fix kvm-dependency package
bd11fb9
@SimonSapin
Install a systemd service file, not upstart, on Ubuntu 16.04
Loading status checks…
42bdb4d
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 12, 2018

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2018

📌 Commit 42bdb4d has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2018

⌛ Testing commit 42bdb4d with merge d37e2c6...
bors-servo added a commit that referenced this pull request Jul 12, 2018
@bors-servo
Auto merge of #853 - servo:kvm, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d37e2c6 
Install a systemd service file, not upstart, on Ubuntu 16.04

Follow up to #852 (comment)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/853)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2018

☀️ Test successful - status-travis
Approved by: nox
Pushing d37e2c6 to master...
@bors-servo bors-servo merged commit 42bdb4d into master Jul 12, 2018
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the kvm branch Jul 12, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 12, 2018

:/

I did run salt-run fileserver.clear_cache just before highstate, though. CC @jdm

          ID: /home/servo/buildbot/slave
    Function: file.recurse
      Result: False
     Comment: Recurse failed: none of the specified sources were found
     Started: 11:59:16.681763
    Duration: 2085.644 ms
     Changes:
@jdm jdm removed the S-needs-deploy label Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @nox @bors-servo @jdm @highfive
You can’t perform that action at this time.