Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInstall Salt from ppa rather than curl|sh #86
Merged
Conversation
|
@bors-servo r+ Thanks for tracking this down! Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
|
bors-servo
pushed a commit
that referenced
this pull request
Jul 29, 2015
Install Salt from ppa rather than curl|sh Old way was fragile, and broke, as noted most recently in #84 (comment) It'd be even better to use Travis's containers, but that's blocked on travis-ci/apt-source-safelist#82 . Once Saltstack is an approved PPA, it'll be trivial to refactor the `.travis.yml` to stop using sudo as described in http://docs.travis-ci.com/user/migrating-from-legacy/ . <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/86) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edunham commentedJul 29, 2015
Old way was fragile, and broke, as noted most recently in #84 (comment)
It'd be even better to use Travis's containers, but that's blocked on travis-ci/apt-source-safelist#82 . Once Saltstack is an approved PPA, it'll be trivial to refactor the
.travis.ymlto stop using sudo as described in http://docs.travis-ci.com/user/migrating-from-legacy/ .