Remove require: user: servo

[Manishearth]

This only works if we have a servo: user.present state somewhere; but
we don't, so we get the following error:

     Comment: The following requisites were not found:
                                 require:
                                     user: servo

We assume the user exists elsewhere anyway, though perhaps we could add
the user.present in case (but when i tried i wasn't able to make that
work)

r? @aneeshusa

cc @jdm

---

This change is 

[aneeshusa]

When is it the case/what command are you using to get that error message? Trying to set ownership to servo/servo won't work very well without a servo user, and the current buildbot master Salt code sets everything up to run under the servo user, so I'd rather make sure the user bits are included when needed and/or point to a better command.

[Manishearth]

Any highstate on servo-master.

require:
  user: servo

does not require there to be a user named servo, it requires there to be a state named servo with a user.present in it.

We depend on a servo user existing all over the place without doing this.

We could add a servo state somewhere if necessary.

[aneeshusa]

I took a look and the issue is that none of the sls files that the master is using which depend on the servo user are pulling in the common.sls file. The better fix here is to make progress on #496 and make sure the states using the servo user - either for ownership or its home directory - a) have an include for common (example) and b) ideally the relevant states depend on the state that sets up the user (example).

[Manishearth]

Ah, that explains why it's somewhat intermittent, it depends on the order.

Opened #883 to fix this.