Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyper-serde to homu. #907

Merged
merged 1 commit into from Jan 25, 2019
Merged

Add hyper-serde to homu. #907

merged 1 commit into from Jan 25, 2019

Conversation

@jdm
Copy link
Member

jdm commented Nov 1, 2018

This change is Reviewable

@jdm
Copy link
Member Author

jdm commented Nov 1, 2018

There's something weird about this repository, possibly because it was transferred:

Traceback (most recent call last):
  File "/home/servo/homu/_venv/bin/bottle.py", line 862, in _handle
    return route.call(**args)
  File "/home/servo/homu/_venv/bin/bottle.py", line 1740, in wrapper
    rv = callback(*a, **ka)
  File "/home/servo/homu/_venv/lib/python3.4/site-packages/homu/server.py", line 207, in callback
    repo = get_repo(repo_label, repo_cfg)
  File "/home/servo/homu/_venv/lib/python3.4/site-packages/homu/server.py", line 58, in get_repo
    assert repo.owner.login == repo_cfg['owner']
AttributeError: 'NoneType' object has no attribute 'owner'
Traceback (most recent call last):
  File "/home/servo/homu/_venv/bin/bottle.py", line 862, in _handle
    return route.call(**args)
  File "/home/servo/homu/_venv/bin/bottle.py", line 1740, in wrapper
    rv = callback(*a, **ka)
  File "/home/servo/homu/_venv/lib/python3.4/site-packages/homu/server.py", line 116, in queue
    if repo_label in g.repos and g.repos[repo_label].treeclosed >= 0:
AttributeError: 'NoneType' object has no attribute 'treeclosed'
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2018

The latest upstream changes (presumably #926) made this pull request unmergeable. Please resolve the merge conflicts.

@nox
Copy link
Member

nox commented Jan 25, 2019

It's an underscore, not an hyphen. :)

@nox nox force-pushed the jdm-patch-36 branch from 9f98233 to 8016af4 Jan 25, 2019
@jdm
Copy link
Member Author

jdm commented Jan 25, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Jan 25, 2019

📌 Commit 8016af4 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jan 25, 2019

Testing commit 8016af4 with merge 15ab267...

bors-servo added a commit that referenced this pull request Jan 25, 2019
Add hyper-serde to homu.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/907)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 25, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 15ab267 to master...

@bors-servo bors-servo merged commit 8016af4 into master Jan 25, 2019
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@jdm
Copy link
Member Author

jdm commented Jan 25, 2019

Traceback (most recent call last):
  File "/home/servo/homu/_venv/bin/bottle.py", line 862, in _handle
    return route.call(**args)
  File "/home/servo/homu/_venv/bin/bottle.py", line 1740, in wrapper
    rv = callback(*a, **ka)
  File "/home/servo/homu/_venv/lib/python3.4/site-packages/homu/server.py", line 310, in github
    repo_label = g.repo_labels[owner, info['repository']['name']]
KeyError: ('servo', 'hyper_serde')

That's from trying to r+ something.

Traceback (most recent call last):
  File "/home/servo/homu/_venv/bin/bottle.py", line 862, in _handle
    return route.call(**args)
  File "/home/servo/homu/_venv/bin/bottle.py", line 1740, in wrapper
    rv = callback(*a, **ka)
  File "/home/servo/homu/_venv/lib/python3.4/site-packages/homu/server.py", line 119, in queue
    g.cfg['repo'][repo_label]['owner'],
KeyError: 'hyper_serde'

That's from trying to visit https://build.servo.org/homu/queue/hyper_serde.

@jdm
Copy link
Member Author

jdm commented Jan 25, 2019

I deployed the wrong version; now https://build.servo.org/homu/queue/hyper_serde works but I can't make it synchronize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.