Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to requests v2.20.0 #912
Merged
Conversation
asajeffrey
force-pushed the
asajeffrey:requestsup
branch
3 times, most recently
from
ca40f01
to
e613de7
|
To get this to pass CI on travis I removed the line: from Without this, we were getting errors on master: |
|
@bors-servo r+ |
|
|
|
@bors-servo r- |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 7, 2018
Upgrade to requests v2.20.0 Hopefully clears up the build errors such as https://travis-ci.org/servo/saltfs/jobs/451570788#L3606 ``` [ FAIL ] Insecure Python packages installed in Homu env: ╒══════════════════════════════════════════════════════════════════════════════╕ │ │ │ /$$$$$$ /$$ │ │ /$$__ $$ | $$ │ │ /$$$$$$$ /$$$$$$ | $$ \__//$$$$$$ /$$$$$$ /$$ /$$ │ │ /$$_____/ |____ $$| $$$$ /$$__ $$|_ $$_/ | $$ | $$ │ │ | $$$$$$ /$$$$$$$| $$_/ | $$$$$$$$ | $$ | $$ | $$ │ │ \____ $$ /$$__ $$| $$ | $$_____/ | $$ /$$| $$ | $$ │ │ /$$$$$$$/| $$$$$$$| $$ | $$$$$$$ | $$$$/| $$$$$$$ │ │ |_______/ \_______/|__/ \_______/ \___/ \____ $$ │ │ /$$ | $$ │ │ | $$$$$$/ │ │ by pyup.io \______/ │ │ │ ╞══════════════════════════════════════════════════════════════════════════════╡ │ REPORT │ ╞════════════════════════════╤═══════════╤══════════════════════════╤══════════╡ │ package │ installed │ affected │ ID │ ╞════════════════════════════╧═══════════╧══════════════════════════╧══════════╡ │ requests │ 2.14.2 │ <2.19.1 │ 36546 │ ╞══════════════════════════════════════════════════════════════════════════════╡ │ The Requests package before 2.19.1 sends an HTTP Authorization header to an │ │ http URI upon receiving a same-hostname https-to-http redirect, which makes │ │ it easier for remote attackers to discover credentials by sniffing the netwo │ │ rk. │ ╘══════════════════════════════════════════════════════════════════════════════╛ ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/912) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedNov 6, 2018
•
edited by larsbergstrom
Hopefully clears up the build errors such as https://travis-ci.org/servo/saltfs/jobs/451570788#L3606
This change is