Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove execute permission from magicleap sdk files #916

Merged
merged 1 commit into from Nov 9, 2018

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Nov 9, 2018

Fixes build problems such as http://build.servo.org/builders/magicleap/builds/11

/Users/servo/magicleap/v0.17.0/tools/toolchains/bin/aarch64-linux-android-clang: Permission denied

This change is Reviewable

@jdm
Copy link
Member

jdm commented Nov 9, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

📌 Commit 43aebfb has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

Testing commit 43aebfb with merge 945dfe8...

bors-servo added a commit that referenced this pull request Nov 9, 2018
Don't remove execute permission from magicleap sdk files

Fixes build problems such as http://build.servo.org/builders/magicleap/builds/11
```
/Users/servo/magicleap/v0.17.0/tools/toolchains/bin/aarch64-linux-android-clang: Permission denied
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/916)
<!-- Reviewable:end -->
@asajeffrey asajeffrey mentioned this pull request Nov 9, 2018
3 of 3 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

💔 Test failed - status-travis

@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing 945dfe8 to master...

@bors-servo bors-servo merged commit 43aebfb into servo:master Nov 9, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm removed the S-needs-deploy label Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.