Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download magicleap signing certificate #918

Merged
merged 1 commit into from Nov 10, 2018

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Nov 9, 2018

Magic Leap apps need to be signed, fortunately we have a dummy signing key.


This change is Reviewable

@jdm
Copy link
Member

jdm commented Nov 9, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

📌 Commit 5b0a0ad has been approved by jdm

bors-servo added a commit that referenced this pull request Nov 9, 2018
Download magicleap signing certificate

Magic Leap apps need to be signed, fortunately we have a dummy signing key.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/918)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

Testing commit 5b0a0ad with merge 2da70a9...

@bors-servo bors-servo mentioned this pull request Nov 9, 2018
@asajeffrey
Copy link
Member Author

asajeffrey commented Nov 9, 2018

Yaml files are dictionaries, you can't have repeated keys, d'oh!

[CRITICAL] Rendering SLS 'base:servo-build-dependencies.mac-magicleap' failed: while constructing a mapping
  in "<unicode string>", line 20, column 3:
      cmd.run:
      ^
found conflicting ID 'cmd.run'
  in "<unicode string>", line 31, column 3:
      cmd.run:
      ^
local:
    - Rendering SLS 'base:servo-build-dependencies.mac-magicleap' failed: while constructing a mapping
        in "<unicode string>", line 20, column 3:
            cmd.run:
            ^
      found conflicting ID 'cmd.run'
        in "<unicode string>", line 31, column 3:
            cmd.run:
            ^
The command ".travis/dispatch.sh" exited with 1.
@asajeffrey asajeffrey force-pushed the asajeffrey:magicleap-signing-key branch from 5b0a0ad to 5e64ca3 Nov 9, 2018
@asajeffrey
Copy link
Member Author

asajeffrey commented Nov 9, 2018

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

📌 Commit 5e64ca3 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

Testing commit 5e64ca3 with merge 3e12b5c...

bors-servo added a commit that referenced this pull request Nov 9, 2018
Download magicleap signing certificate

Magic Leap apps need to be signed, fortunately we have a dummy signing key.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/918)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing 3e12b5c to master...

@bors-servo bors-servo merged commit 5e64ca3 into servo:master Nov 10, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@asajeffrey asajeffrey mentioned this pull request Nov 12, 2018
3 of 3 tasks complete
@jdm jdm removed the S-needs-deploy label Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.