Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate on magicleap #921

Merged
merged 1 commit into from Nov 15, 2018
Merged

Gate on magicleap #921

merged 1 commit into from Nov 15, 2018

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Nov 15, 2018

The magicleap builders are pretty reliably green (when I'm not messing around with the app that is) so we should be file gating on the build.


This change is Reviewable

@asajeffrey
Copy link
Member Author

asajeffrey commented Nov 15, 2018

r? @jdm

@jdm
Copy link
Member

jdm commented Nov 15, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2018

📌 Commit de6b192 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2018

Testing commit de6b192 with merge d970b38...

bors-servo added a commit that referenced this pull request Nov 15, 2018
Gate on magicleap

The magicleap builders are pretty reliably green (when I'm not messing around with the app that is) so we should be file gating on the build.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/921)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing d970b38 to master...

@bors-servo bors-servo merged commit de6b192 into servo:master Nov 15, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details
@jdm jdm removed the S-needs-deploy label Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.