Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate gstreamer binaries with proper libswscale and libswresample na… #937
+10
−2
Conversation
…ming
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 9, 2019
Update gstreamer binaries with proper libswscale and libswresample na… …ming <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/937) <!-- Reviewable:end -->
|
I tried this locally as much as I could (with gst-inspect only), and it seems to work. I deployed and run a try run to really test it. Let's not merge this until we know it works. @bors-servo r- |
|
This seems to work now. It's already deployed. @bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 10, 2019
Update gstreamer binaries with proper libswscale and libswresample na… …ming <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/937) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJan 9, 2019
•
edited by larsbergstrom
…ming
This change is