Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `jq` in server-build-dependencies for upstream WPT sync #955

Merged
merged 1 commit into from Apr 6, 2019
Merged

Add `jq` in server-build-dependencies for upstream WPT sync #955

merged 1 commit into from Apr 6, 2019

Conversation

@CYBAI
Copy link
Contributor

CYBAI commented Apr 6, 2019 •
edited by larsbergstrom

We missed to add it in wrong place in #954.
As @jdm mentioned, we should add jq in server build dependencies instead; or, the upstream wpt webhook one will only affect servo-mac1.

This change is Reviewable
@CYBAI
Add `jq` in server-build-dependencies
Loading status checks…
677b14c 
We should add `jq` in server build dependencies instead; or, the
upstream wpt webhook one will only affect servo-mac1.
@jdm
Copy link
Member

jdm commented Apr 6, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2019

📌 Commit 677b14c has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2019

⌛ Testing commit 677b14c with merge 095c151...
bors-servo added a commit that referenced this pull request Apr 6, 2019
@bors-servo
Auto merge of #955 - CYBAI:upstream-wpt-jq, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
095c151 
Add `jq` in server-build-dependencies for upstream WPT sync

We missed to add it in wrong place in  #954.
As @jdm mentioned, we should add `jq` in server build dependencies instead; or, the upstream wpt webhook one will only affect servo-mac1.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 095c151 to master...
@bors-servo bors-servo merged commit 677b14c into servo:master Apr 6, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@CYBAI CYBAI deleted the CYBAI:upstream-wpt-jq branch Apr 6, 2019
@jdm jdm removed the S-needs-deploy label Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@CYBAI @jdm @bors-servo @highfive
You can’t perform that action at this time.