Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade linux CI from trusty to xenial #957

Merged
merged 7 commits into from May 23, 2019
Merged

Upgrade linux CI from trusty to xenial #957

merged 7 commits into from May 23, 2019

Conversation

@jdm
Copy link
Member

jdm commented Apr 26, 2019

I'm going to upgrade all the machines, deploy the changes in this branch, and we can merge when the process is done.

I have successfully completed builds on both a new linux builder and a new linux cross builder that were upgraded from trusty.


This change is Reviewable

@jdm
Copy link
Member Author

jdm commented Apr 26, 2019

  • servo-linux1
  • servo-linux2
  • servo-linux3
  • servo-linux4
  • servo-linux5
  • servo-linux6
  • servo-linux-cross1
  • servo-linux-cross2
  • servo-linux-cross3
@jdm
Copy link
Member Author

jdm commented Apr 26, 2019

Current status:

  • all common update steps performed on all machines
  • salt-minion service has been started on every machine
  • highstate completed for all machines
  • attempting merge of servo/servo#23182
@jdm
Copy link
Member Author

jdm commented Apr 26, 2019

I just noticed all of the linux bustage on travis, which is worrying!

@jdm
Copy link
Member Author

jdm commented Apr 26, 2019

Based on https://www.reddit.com/r/saltstack/comments/ae85xg/installingupdating_python_module/, it may be possible to downgrade the version of pip on TravisCI builds to avoid this error:

----------
          ID: buildbot-slave-dependencies
    Function: pip.installed
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1905, in call
                  **cdata['kwargs'])
                File "/usr/lib/python2.7/dist-packages/salt/loader.py", line 1830, in wrapper
                  return f(*args, **kwargs)
                File "/usr/lib/python2.7/dist-packages/salt/states/pip_state.py", line 681, in installed
                  out = _check_pkg_version_format(pkg)
                File "/usr/lib/python2.7/dist-packages/salt/states/pip_state.py", line 147, in _check_pkg_version_format
                  install_req = InstallRequirement.from_line(pkg)
              AttributeError: type object 'InstallRequirement' has no attribute 'from_line'

That leaves these PPA issues, which don't appear on our builders because the files are already present during the upgrade:

----------
          ID: /etc/apt/sources.list.d/openjdk-r-ppa-trusty.list
    Function: file.exists
      Result: False
     Comment: Specified path /etc/apt/sources.list.d/openjdk-r-ppa-trusty.list does not exist
     Started: 15:50:23.105446
    Duration: 0.825 ms
     Changes:   
----------
          ID: cmake-ppa
    Function: pkgrepo.managed
      Result: False
     Comment: Failed to configure repo 'cmake-ppa': Unable to add PPA 'george-edison55/cmake-3.x'. '[u'apt-add-repository', u'-y', u'ppa:george-edison55/cmake-3.x']' exited with status 1: 'gpg: keyring `/tmp/tmpuj417wiv/secring.gpg' created
              gpg: keyring `/tmp/tmpuj417wiv/pubring.gpg' created
              gpg: requesting key 828AB726 from hkp server keyserver.ubuntu.com
              gpg: no valid OpenPGP data found.
              gpg: Total number processed: 0
              gpg: keyserver communications error: keyserver helper general error
              gpg: keyserver communications error: unknown pubkey algorithm
              gpg: keyserver receive failed: unknown pubkey algorithm'
----------
          ID: ffmpeg-ppa
    Function: pkgrepo.managed
      Result: False
     Comment: Failed to configure repo 'ffmpeg-ppa': Unable to add PPA 'jonathonf/ffmpeg-3'. '[u'apt-add-repository', u'-y', u'ppa:jonathonf/ffmpeg-3']' exited with status 1: 'gpg: keyring `/tmp/tmpwd7blizj/secring.gpg' created
              gpg: keyring `/tmp/tmpwd7blizj/pubring.gpg' created
              gpg: requesting key F06FC659 from hkp server keyserver.ubuntu.com
              gpg: no valid OpenPGP data found.
              gpg: Total number processed: 0
              gpg: keyserver communications error: keyserver helper general error
              gpg: keyserver communications error: unknown pubkey algorithm
              gpg: keyserver receive failed: unknown pubkey algorithm'
----------
          ID: ttf-mscorefonts-installer
    Function: debconf.set
      Result: False
     Comment: State 'debconf.set' was not found in SLS 'servo-build-dependencies'
              Reason: 'debconf.set' is not available.
     Changes:   
@jdm jdm force-pushed the jdm:xenial branch 2 times, most recently from b86980e to 2d66278 May 22, 2019
@jdm
Copy link
Member Author

jdm commented May 23, 2019

It's greeeeeeeeeeeen!

@jdm jdm force-pushed the jdm:xenial branch 2 times, most recently from 8c0a9af to cf4dea7 May 23, 2019
@jdm
Copy link
Member Author

jdm commented May 23, 2019

@jdm
Copy link
Member Author

jdm commented May 23, 2019

The salt upgrade works around saltstack/salt#49967 which was fixed in 2018.3.4. The python upgrade works around https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings.

ExecStart=/usr/bin/Xvfb :0 -screen 0 1280x960x24 +extension RANDR +extension RENDER +extension GLX

[Install]
WantedBy=multi-user.target

This comment has been minimized.

@Manishearth

Manishearth May 23, 2019

Member

newline at eof?

@jdm jdm force-pushed the jdm:xenial branch from cf4dea7 to 5cfa804 May 23, 2019
@jdm
Copy link
Member Author

jdm commented May 23, 2019

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2019

📌 Commit 5cfa804 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2019

Testing commit 5cfa804 with merge f24e048...

bors-servo added a commit that referenced this pull request May 23, 2019
Upgrade linux CI from trusty to xenial

I'm going to upgrade all the machines, deploy the changes in this branch, and we can merge when the process is done.

I have successfully completed builds on both a new linux builder and a new linux cross builder that were upgraded from trusty.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/957)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2019

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing f24e048 to master...

@bors-servo bors-servo merged commit 5cfa804 into servo:master May 23, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.