Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state files for Salt best practices #96

Merged
merged 10 commits into from Sep 22, 2015
Merged

Update state files for Salt best practices #96

merged 10 commits into from Sep 22, 2015

Commits on Sep 22, 2015

  1. Move state files into respective folders. 

    Take advantage of the init.sls convention to clean up top level folder.
    @aneeshusa
    aneeshusa committed Sep 22, 2015
    e2ec298

  2. Remove empty state file.

    @aneeshusa
    aneeshusa committed Sep 22, 2015
    23d5aab

  3. Reduce redundancy in the common state file with jinja. 

    Factor out common subexpressions based on system type.
    @aneeshusa
    aneeshusa committed Sep 22, 2015
    bf70053

  4. Use jinja loops to remove more redundancy in the common state file. 

    Combine similar states with templating. Ideally, the variable data
(hostnames, ips, usernames) - the 'hosts' and 'ssh_users' fields -
would be used via pillar to allow changing the state file less often.
    @aneeshusa
    aneeshusa committed Sep 22, 2015
    d4667c2

  5. Consolidate states for conciseness and speed. 

    The pkgs parameter in particular provides a speed
boost by installing all pkgs in one transaction.
    @aneeshusa
    aneeshusa committed Sep 22, 2015
    775c6c5

  6. Do a bit of linting on other state files. 

    Reuse conditional logic and configuration from other places,
clean up unused code/duplicated functionality,
and standardize a bit of formatting.

Eliminate any traces of previous misspellings.
    @aneeshusa
    aneeshusa committed Sep 22, 2015
    98ff365

  7. Fix syntax mistakes.

    @aneeshusa
    aneeshusa committed Sep 22, 2015
    bdf3877

  8. Fix another syntax mistake.

    @aneeshusa
    aneeshusa committed Sep 22, 2015
    873188f

  9. Fix a name mispelling. Sorry about that!

    @aneeshusa
    aneeshusa committed Sep 22, 2015
    c4a3dfa

  10. Combine a few more states together. 

    Also fix jinja templating import error.
    @aneeshusa
    aneeshusa committed Sep 22, 2015
    Loading status checks…
    b015a90
You can’t perform that action at this time.