Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gstreamer dependency to 1.16 (with webrtc enabled) #961

Merged
merged 1 commit into from May 15, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented May 15, 2019

Undeployed, untested, but unpacking these on the servers and running gst-inspect-1.0 webrtcbin with the appropriate paths works.

Unsure if deploying this will break things, but I've had servo work fine with 1.15 so i suspect it's backwards compatible

r? @jdm


This change is Reviewable

@Manishearth Manishearth force-pushed the Manishearth:gstup branch from d5e4768 to ec4a598 May 15, 2019
@ferjm
Copy link
Member

ferjm commented May 15, 2019

@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2019

📌 Commit ec4a598 has been approved by ferjm

@highfive highfive assigned ferjm and unassigned jdm May 15, 2019
bors-servo added a commit that referenced this pull request May 15, 2019
Update gstreamer dependency to 1.16 (with webrtc enabled)

Undeployed, untested, but unpacking these on the servers and running `gst-inspect-1.0 webrtcbin` with the appropriate paths works.

Unsure if deploying this will break things, but I've had servo work fine with 1.15 so i suspect it's backwards compatible

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/961)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2019

Testing commit ec4a598 with merge a23c992...

@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2019

☀️ Test successful - checks-travis
Approved by: ferjm
Pushing a23c992 to master...

@bors-servo bors-servo merged commit ec4a598 into servo:master May 15, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.