Skip to content

/ servo-android-glue

forked from metajack/servo-android-glue
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Servo on Android #1

Merged
merged 5 commits into from Mar 4, 2014
Merged

Fixes for Servo on Android #1

merged 5 commits into from Mar 4, 2014

Conversation

@larsbergstrom
Copy link

larsbergstrom commented Feb 19, 2014

@aydinkim's fixes clean up dead code and match changes made in the main crate to exported function names.

My changes add redirection of RUST_LOG and clean up the build process, both to work on OSX and to explicitly choose the target SDK version.

r? @aydinkim or @metajack
aydin.kim and others added 5 commits Dec 9, 2013
aydin.kim @larsbergstrom
change entrance method to rust
bbef2e3
aydin.kim @larsbergstrom
fix makefile to generate sym link of libservo
de95748
aydin.kim @larsbergstrom
change libservo name to be excluding hash
80e6a70
aydin.kim @larsbergstrom
code cleanup
1aff492
@larsbergstrom
Add support for redirecting RUST_LOG output to the Android console for
ff9d6a6 
debugging purposes.

The Makefile is also changed to work on OSX as well (ls and find do
not have as many flags as some of the more modern Linux systems).

Finally, explicitly build against the android-18 platform.
@larsbergstrom
Copy link
Author

larsbergstrom commented Mar 4, 2014

@metajack Can you land this? I'm going to need it once I get the Rust upgrade past OSX.
@metajack

This comment has been minimized.

Sign in to view
Copy link

metajack commented on de95748 Mar 4, 2014

This seems like a bug in how it's built.
@metajack

This comment has been minimized.

Sign in to view
Copy link

metajack commented on 80e6a70 Mar 4, 2014

This is kind of yuck, but I'm not sure of a better way.
@metajack

This comment has been minimized.

Sign in to view
Copy link

metajack commented on ff9d6a6 Mar 4, 2014

r+
metajack added a commit that referenced this pull request Mar 4, 2014
@metajack
Merge pull request #1 from larsbergstrom/new_android
79e68fa 
Fixes for Servo on Android
@metajack metajack merged commit 79e68fa into servo:master Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@larsbergstrom @metajack
You can’t perform that action at this time.