Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport for Android on February Rust Upgrade #2
Conversation
|
r? @metajack |
This comment has been minimized.
This comment has been minimized.
metajack
commented on jni/android-dl.cpp in 5196a2a
Apr 2, 2014
|
Why do all these need to be commented out? Can we remove them instead? |
This comment has been minimized.
This comment has been minimized.
|
I left them because I seem to need them every time we do a Rust upgrade and they change something with linking, but I don't like leaving them enabled because it's ~10k lines of debug log output. Would you prefer if I put them under an |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 5196a2a
Apr 2, 2014
|
Looks good other than minor comment above. |
This comment has been minimized.
This comment has been minimized.
metajack
replied
Apr 2, 2014
|
r+ |
metajack
added a commit
that referenced
this pull request
Apr 2, 2014
Support for Android on February Rust Upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedApr 1, 2014
dlopensteps when working with linker issues