Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a static version of browser.html's about:newtab for easy testing #23

Merged
merged 1 commit into from Jun 6, 2016

Conversation

@tschneidereit
Copy link
Contributor

tschneidereit commented Jun 3, 2016

r? @metajack

The list of included sites isn't final by any means, of course, but it's what we have in browser.html right now.


This change is Reviewable

@Manishearth
Copy link
Member

Manishearth commented Jun 3, 2016

Are we allowed to use these images in this repo?

@tschneidereit
Copy link
Contributor Author

tschneidereit commented Jun 3, 2016

Are we allowed to use these images in this repo?

We do have them in the browser.html repo, so I'm assuming that has been
checked.

@Ms2ger
Copy link

Ms2ger commented Jun 6, 2016

That seems implausible... @metajack?

@tschneidereit
Copy link
Contributor Author

tschneidereit commented Jun 6, 2016

That seems implausible... @metajack https://github.com/metajack?

I tend to agree. Perhaps we should just not land this for now.

@metajack
Copy link
Contributor

metajack commented Jun 6, 2016

I think this is likely to be an allowed use, but it is easy to check. For example: https://www.youtube.com/yt/brand/using-logo.html lists the rules for YouTube logo usage.

This particular page contains more icons than we will need, so we only need to check the ones that work well in Servo.

@metajack
Copy link
Contributor

metajack commented Jun 6, 2016

As this is no worse that what we're already doing, I'm going to land this so I can do the surgery on it to get it to have the correct tiles.

@metajack
Copy link
Contributor

metajack commented Jun 6, 2016

@metajack metajack merged commit d87867a into servo:gh-pages Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.