Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Chinese localization home page #37

Closed
wants to merge 4 commits into from

Conversation

@3442853561
Copy link
Contributor

3442853561 commented Oct 30, 2016

Added the Chinese localization home page


This change is Reviewable

@Manishearth
Copy link
Member

Manishearth commented Oct 30, 2016

r? @KiChjang @shinglyu (not sure if either of you can read simplified)

Copy link
Member

KiChjang left a comment

大致上沒有什麼大問題,而且翻譯得相當好,有勞您用心辦工!@shinglyu可能有更多建議。


<p>Servo项目是一个由 Mozilla Research 创建的全球社区。其中有个人贡献者,也不乏 Mozilla 、三星这样的公司。</p>

<p> Servo 目前支持 Linux、OSX、Windows、安卓和 Gonk(Firefox OS)。</p>

This comment has been minimized.

@KiChjang

KiChjang Oct 30, 2016

Member

咱們好像已經不再支持Gonk了,可否改寫一下?

<div class='row'>
<div class='col-sm-offset-2 col-sm-8'>
<h2 class='header'>入门</h2>
<h3>准备工作</h3>

This comment has been minimized.

@KiChjang

KiChjang Oct 30, 2016

Member

準備工作有點兒怪怪的,《系統所需》或者更恰當。

查看页面底部链接以了解更多信息。为了 Servo 的蓬勃发展,加入全球数百贡献者团队吧!
</p>

<p>对 Servo 或其依赖关系的贡献应该以 GitHub pull 的形式提交。 每个 pull 请求将由核心贡献者(有权限修补程序的人员)审核,合并到主分支中或给出反馈,以获取所需的更改。 所有贡献应遵循此形式,包括来自核心贡献者的贡献。

This comment has been minimized.

@KiChjang

KiChjang Oct 30, 2016

Member

GitHub Pull Request

此举是为了防止在同一问题上贡献者们的重复劳动。
</p>

<p>如果您在找那些显而易见的漏洞,请查看 GitHub 上

This comment has been minimized.

@KiChjang

KiChjang Oct 30, 2016

Member

這裏缺乏了E-Easy容易收復的意思。


<li>如果您的补丁没有得到审核,或者您需要特定的人来审核,
您可以 @ 请求审核人员在 pull 请求或评论中要求审核,
您也可以在 irc.mozilla.org的 #servo 上要求审核 。

This comment has been minimized.

@KiChjang

KiChjang Oct 30, 2016

Member

這裏或者可以加上我和@shinglyu的名字,以便懂漢語的貢獻者尋求拹助。

index.html Outdated

<footer>
<p>Our site in other languages:
<a href="/index(zh-CN).html">简体中文</a>

This comment has been minimized.

@KiChjang

KiChjang Oct 30, 2016

Member

rust-lang.org 本土化網頁的URL是/zh-CN/index.html,跟隨它們的格式或者會好一些,而且URL不太適宜含有括號。

This comment has been minimized.

@3442853561

3442853561 Oct 31, 2016

Author Contributor

非常感谢您的建议,我今天会修复这些问题

@notriddle
Copy link
Contributor

notriddle commented Oct 30, 2016

Is 16.10.30.21.28 really a good commit message?

@3442853561
Copy link
Contributor Author

3442853561 commented Oct 31, 2016

@notriddle there is some little bugs I will fix it today.

3442853561 added 2 commits Oct 31, 2016
接受了若干来自 KiChjang 的改进建议
修复本土化链接
@3442853561
Copy link
Contributor Author

3442853561 commented Oct 31, 2016

@KiChjang I completed the localization.

@jdm
Copy link
Member

jdm commented Oct 31, 2016

@3442853561
Copy link
Contributor Author

3442853561 commented Oct 31, 2016

@shinglyu
Copy link
Member

shinglyu commented Nov 1, 2016

Sorry I might be a little bit late to give feedbacks (it was national holiday yesterday), but I did found some nit, you can either fix it or consider giving a followup PR.

Copy link
Member

shinglyu left a comment

感謝您的貢獻 (您也同時有幫忙 Rust 語言中文化對吧?) 如果已經準備 merge 了您可以考慮之後再上一個 PR 修正這些錯誤,或是您願意現在一起修掉我也會很感激!

<br>
<div class='row'>
<div class='col-sm-offset-2 col-sm-8 col-lg-4'>
<p class='info'>由Mozilla赞助并由全新的系统级编程语言 <a href='https://www.rust-lang.org'>Rust</a>,

This comment has been minimized.

@shinglyu

shinglyu Nov 1, 2016

Member

最好在 Mozilla 與中文字之間留一個空白


</p>

<h3>构建<</h3>

This comment has been minimized.

@shinglyu

shinglyu Nov 1, 2016

Member

多餘的 "<"

此举是为了防止在同一问题上贡献者们的重复劳动。
</p>

<p>如果您在找那些显而易见的漏洞,请查看 GitHub 上

This comment has been minimized.

@shinglyu

shinglyu Nov 1, 2016

Member

這邊並不只是顯而易見,而且是強調對於初學者來說非常簡單的漏洞

</p>

<p>如果您在找那些显而易见的漏洞,请查看 GitHub 上
<a href="https://github.com/servo/servo/labels/E-easy">E-Easy 的 issue 标签</a> 。 (因为 E-Easy 更适于接收这些漏洞的报告)

This comment has been minimized.

@shinglyu

shinglyu Nov 1, 2016

Member

"(因为 E-Easy 更适于接收这些漏洞的报告)" 抱歉,這句我不太理解?

<a href="https://github.com/servo/servo/labels/E-easy">E-Easy 的 issue 标签</a> 。 (因为 E-Easy 更适于接收这些漏洞的报告)
</p>

<p>有关如何开始使用 Servo 的详细信息,请参阅

This comment has been minimized.

@shinglyu

shinglyu Nov 1, 2016

Member

"開始修改" 可能好一點

<a href="https://github.com/servo/servo/blob/master/docs/HACKING_QUICKSTART.md">HACKING_QUICKSTART.md</a>
</p>

<h3>Pull 请求清单</h3>

This comment has been minimized.

@shinglyu

shinglyu Nov 1, 2016

Member

"檢查清單" 會不會比 "清單" 明確一點?

This comment has been minimized.

@KiChjang

KiChjang Nov 1, 2016

Member

其實Pull Request 是否專有名詞? 譯為《Pull 請求》好像不對...

如需中文服务请联系:[KiChjang](https://github.com/KiChjang) 和 [shinglyu](https://github.com/shinglyu)
</li>

<li>为新功能或修复错误添加相关测试。对于DOM的修改,通常需要一个Web平台测试、布局及反复测试。有关详细信息,请参阅

This comment has been minimized.

@shinglyu

shinglyu Nov 1, 2016

Member

Web 一字旁請加空白

如需中文服务请联系:[KiChjang](https://github.com/KiChjang) 和 [shinglyu](https://github.com/shinglyu)
</li>

<li>为新功能或修复错误添加相关测试。对于DOM的修改,通常需要一个Web平台测试、布局及反复测试。有关详细信息,请参阅

This comment has been minimized.

@shinglyu

shinglyu Nov 1, 2016

Member

如果我理解無誤,原文應該是 "DOM 的修改通常需要一個 Web 平台測試;布局的修改需要一個參考測試 (reftest)"

如果它不能与主分支完全合并,您可能会被要求退回您的更改。
</li>

<li>请不要将子模块更新放在您的pull请求中,除非它们影响提交。

This comment has been minimized.

@shinglyu

shinglyu Nov 1, 2016

Member

pull 前後請加空白

接受了一些新的修改意见
@3442853561
Copy link
Contributor Author

3442853561 commented Nov 3, 2016

完成了修改。
PS:我的确也在帮助 Rust 完成本土化。

@3442853561
Copy link
Contributor Author

3442853561 commented Nov 8, 2016

@shinglyu
Copy link
Member

shinglyu commented Nov 10, 2016

您方便把四個 commit 壓 (squash) 成一個嗎? 詳細方法可以參考這篇 另外請在壓完的 commit 中寫比較敘述性的 commit message, 例如 "Added zh-CN translation for the homepage" 完成後我們就可以 merge 了。感謝您的細心貢獻。

@3442853561
Copy link
Contributor Author

3442853561 commented Nov 12, 2016

#38

@3442853561 3442853561 closed this Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.