Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing Page for Servo #4

Closed
wants to merge 5 commits into from
Closed

Landing Page for Servo #4

wants to merge 5 commits into from

Conversation

@lucywyman
Copy link
Contributor

lucywyman commented Nov 6, 2015

Review on Reviewable

@lucywyman
Copy link
Contributor Author

lucywyman commented Nov 6, 2015

@edunham Ok, I addressed:

  1. Adding contributing information
  2. Doge

Do you want the news section to just pull the most recent blog post? List the most recent three links from the blog? I'm going to try the latter, but let me know if that's not what you were thinking!

I'll also try to have more flexbox ;)

@edunham
Copy link
Contributor

edunham commented Nov 6, 2015

@lucywyman Including the most recent blog post could be really neat!

Could you link that prototype site that you mentioned on IRC from here?

servo/servo#8365

@edunham
Copy link
Contributor

edunham commented Nov 6, 2015

One tiny nitpick, which I don't think should block merge: In a small window, the headings at the top overlap rather than stacking. screenshot

Would it be possible to make them stack vertically when the screen is too small, or disappear behind a hamburger-menu button the way sites like https://viewsourceconf.org/ do on mobile?

@edunham
Copy link
Contributor

edunham commented Nov 10, 2015

Closing as discussed in servo/servo#8365 -- please PR this awesome content into the current site!

@edunham edunham closed this Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.