Skip to content

/ servo.org

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Korean translation for the homepage #54

Closed
wants to merge 13 commits into from
Closed

Added the Korean translation for the homepage #54

wants to merge 13 commits into from
+263 −4

Conversation

@Hikai
Copy link
Contributor

Hikai commented Jan 19, 2018 •
edited by larsbergstrom

Added the Korean translation for the homepage

This change is Reviewable
Hikai added 7 commits Jan 19, 2018
@Hikai
Create index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
677fa29
@Hikai
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6811e8a
@Hikai
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
e1a1ec4
@Hikai
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9ecc7d5
@Hikai
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
538d209
@Hikai
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
3cbaa87
@Hikai
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
17e271d
@Hikai Hikai mentioned this pull request Jan 20, 2018
Open
@tigercosmos
tigercosmos reviewed Jan 20, 2018
View changes
ko-KR/index.html
<div class='row' id='languages'>
<div class='col-sm-12'>

<p>다른 언어의 페이지:

This comment has been minimized.

Sign in to view
@tigercosmos

tigercosmos Jan 20, 2018

Contributor

Other languages pages need to add Korean.

This comment has been minimized.

Sign in to view
@Hikai

Hikai Jan 20, 2018

Author Contributor

I'm sorry, I misunderstand at first. I edited it.
@tigercosmos
tigercosmos reviewed Jan 20, 2018
View changes
ko-KR/index.html Outdated
<meta charset='utf-8'>
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>Servo, 병렬 브라우저 엔진</title>
<link rel='stylesheet' href='css/bootstrap.css'/>

This comment has been minimized.

Sign in to view
@tigercosmos

tigercosmos Jan 20, 2018 •
edited

Contributor

I suspect this css href will fail, since it is relative path. /css/bootstrap.css may work

This comment has been minimized.

Sign in to view
@Hikai

Hikai Jan 20, 2018

Author Contributor

yeah exactly. I edited it.
Hikai added 6 commits Jan 20, 2018
@Hikai
css link edit
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
fe5aaa0
@Hikai
Add other language page
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9c831d0
@Hikai
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f3bc228
@Hikai
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
efcb49c
@Hikai
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a845a75
@Hikai
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
ae2700f
@tigercosmos
Copy link
Contributor

tigercosmos commented Jan 20, 2018

you may need to squash commit
@Hikai
Copy link
Contributor Author

Hikai commented Jan 20, 2018

I don't know squash commit. Therefore, I close this PR and new fork, new PR.
@Hikai Hikai closed this Jan 20, 2018
@jdm
Copy link
Member

jdm commented Jan 20, 2018

https://www.devroom.io/2011/07/05/git-squash-your-latests-commits-into-one/ is a good guide.
@Hikai
Copy link
Contributor Author

Hikai commented Jan 20, 2018

Thank you. But my commit log was twisted. I again fork and pull request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigercosmos tigercosmos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Hikai @tigercosmos @jdm
You can’t perform that action at this time.