Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Japanese translation for homepage. (Re PR) #60

Merged
merged 1 commit into from Feb 12, 2018

Conversation

@Hikai
Copy link
Contributor

Hikai commented Feb 5, 2018

Added the Japanese translation for homepage. again PR.

I made a mistake and did it again. I'm sorry.
(Rebase is too hard.)

Thank you for @saneyuki for review!


This change is Reviewable

Copy link
Member

tetsuharuohzeki left a comment

@Hikai Thank you for your response!

I reviewed your updated patch.

  • I find more nice phrase at some points. They are my mistaken review in #58. I'm sorry.
  • I find some miss-spells. Please fix them.
<h2 class='header'>開発に参加する</h2>

<p id='contributing'>
Servoプロジェクトは、経験が豊富な開発者から初心者まで、多くの皆さんによる開発への参加を受け入れます。

This comment has been minimized.

@tetsuharuohzeki

tetsuharuohzeki Feb 6, 2018

Member

多くの皆さんによる開発への参加を受け入れます。

多くの皆さんによる開発への参加を歓迎しています。

would be more nice.

Servoプロジェクトは、経験が豊富な開発者から初心者まで、多くの皆さんによる開発への参加を受け入れます。

Servoをさらに良いものにする為に、全世界で数百人の開発者が一緒に開発に取り組んでいます。
この取り組みに参加するにはページの末尾に書かれたリンクを参照してください。

This comment has been minimized.

@tetsuharuohzeki

tetsuharuohzeki Feb 6, 2018

Member

ページの末尾に書かれたリンクを

ページの末尾に記載されたリンクを


<p>
私たちは
<a href="https://www.rust-lang.org/conduct.html">Rust 行動規範</a>

This comment has been minimized.

@tetsuharuohzeki

tetsuharuohzeki Feb 6, 2018

Member

Rust 行動規範

Rustの行動規範

<p>
Servoの開発者の間では
<a href="https://wiki.mozilla.org/IRC">irc.mozilla.org</a>の#servoチャンネルが活発に使用されています。
また、<a href="https://lists.mozilla.org/listinfo/dev-servo">開発メールリグリスト</a>でも議論が行われており、自由に参加できます。

This comment has been minimized.

@tetsuharuohzeki

tetsuharuohzeki Feb 6, 2018

Member

開発メールリグリスト

開発メーリングリスト


<p>
もし簡単なバグを探しているのならGitHubの
<a href="https://github.com/servo/servo/labels/E-easy">E-Easy issue タグ</a>

This comment has been minimized.

@tetsuharuohzeki

tetsuharuohzeki Feb 6, 2018

Member

E-Easy issue タグ

E-Easy ラベル

<h4>一般的なビルド方法</h4>
<p>
Servoを開発モードでビルドすると開発に役立ちます。
しかし、生成されたバイナリの動作は非常に遅いです。

This comment has been minimized.

@tetsuharuohzeki

tetsuharuohzeki Feb 6, 2018

Member

非常に遅いです

非常に低速なことに注意してください。

would be more nice.

@Hikai Hikai force-pushed the Hikai:patche-jp branch from 9ff0e58 to 62bc652 Feb 11, 2018
@Hikai
Copy link
Contributor Author

Hikai commented Feb 11, 2018

Sorry, I late to commit because so busy.
Is this the right way to do a commit squash?

And Thank you for your review!

@jdm
Copy link
Member

jdm commented Feb 12, 2018

Looks great. Thanks!

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Feb 12, 2018

I feel this translation is good.


@Hikai

Sorry, I late to commit because so busy.
Is this the right way to do a commit squash?

No problem!
Yes, squash is the right wary. Thank YOU!


@jdm

Could you review this pull request for the technical aspect?
I can review the translation feeling. But I'm not sure about this repository.

@jdm
Copy link
Member

jdm commented Feb 12, 2018

Thanks for reviewing the language changes @saneyuki!

@jdm jdm merged commit 63aced0 into servo:gh-pages Feb 12, 2018
@Hikai Hikai deleted the Hikai:patche-jp branch Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.