Skip to content
Permalink
Browse files

Properly open file as 'wb' in archive_deterministically

  • Loading branch information
marmeladema committed Oct 28, 2019
1 parent 3f48f28 commit 267eaad4ebcc26337956ae298babb98694554a1c
Showing with 2 additions and 2 deletions.
  1. +2 −2 python/servo/command_base.py
@@ -110,9 +110,9 @@ def reset(tarinfo):
# packaging (in case of exceptional situations like running out of disk space).
# TODO do this in a temporary folder after #11983 is fixed
temp_file = '{}.temp~'.format(dest_archive)
with os.fdopen(os.open(temp_file, os.O_WRONLY | os.O_CREAT, 0o644), 'w') as out_file:
with os.fdopen(os.open(temp_file, os.O_WRONLY | os.O_CREAT, 0o644), 'wb') as out_file:
if dest_archive.endswith('.zip'):
with zipfile.ZipFile(temp_file, 'w', zipfile.ZIP_DEFLATED) as zip_file:
with zipfile.ZipFile(out_file, 'w', zipfile.ZIP_DEFLATED) as zip_file:
for entry in file_list:
arcname = entry
if prepend_path is not None:

0 comments on commit 267eaad

Please sign in to comment.
You can’t perform that action at this time.