Skip to content

Commit

Permalink
Disable logging in bindgen to reduce code size
Browse files Browse the repository at this point in the history
This disables bindgen's `logging` feature, which builds `env_logger`
with default features, including regex support.  Disabling it allows
Gecko to build `env_logger` without the `regex` crate, reducing code
size.

Part of https://bugzilla.mozilla.org/show_bug.cgi?id=1444097
  • Loading branch information
mbrubeck committed Mar 8, 2018
1 parent 8133f78 commit 2f2bfb2
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 51 deletions.
48 changes: 0 additions & 48 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion components/style/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ kernel32-sys = "0.2"
[build-dependencies]
lazy_static = "1"
log = "0.3"
bindgen = { version = "0.33.1", optional = true }
bindgen = { version = "0.33.1", optional = true, default-features = false }
regex = {version = "0.2", optional = true}
walkdir = "1.0"
toml = {version = "0.2.1", optional = true, default-features = false}
2 changes: 1 addition & 1 deletion ports/geckolib/tests/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ doctest = false
atomic_refcell = "0.1"
cssparser = "0.23.0"
cstr = "0.1.2"
env_logger = "0.4"
env_logger = { version = "0.4", default-features = false }
euclid = "0.17"
geckoservo = {path = "../../../ports/geckolib"}
libc = "0.2"
Expand Down
1 change: 0 additions & 1 deletion servo-tidy.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ packages = [
"quote",
"unicode-xid",
"log",
"env_logger",
]
# Files that are ignored for all tidy and lint checks.
files = [
Expand Down

0 comments on commit 2f2bfb2

Please sign in to comment.