Skip to content
Permalink
Browse files

Fixed codegen error regarding Uint8ClampedArray

  • Loading branch information...
ebalint committed Dec 16, 2014
1 parent fb5c1be commit 3036c8d21d7e529e71d78898788f0c211a06967f
@@ -4020,8 +4020,7 @@ def members():
elif m.isAttr() and not m.isStatic():
name = CGSpecializedGetter.makeNativeName(descriptor, m)
infallible = 'infallible' in descriptor.getExtendedAttributes(m, getter=True)
needCx = typeNeedsCx(m.type)
yield name, attribute_arguments(needCx), return_type(descriptor, m.type, infallible)
yield name, attribute_arguments(typeNeedsCx(m.type, True)), return_type(descriptor, m.type, infallible)

if not m.readonly:
name = CGSpecializedSetter.makeNativeName(descriptor, m)
@@ -4030,7 +4029,7 @@ def members():
rettype = "()"
else:
rettype = "ErrorResult"
yield name, attribute_arguments(needCx, m.type), rettype
yield name, attribute_arguments(typeNeedsCx(m.type, False), m.type), rettype

if descriptor.proxy:
for name, operation in descriptor.operations.iteritems():
@@ -17,7 +17,7 @@ use dom::bindings::utils::{Reflector, Reflectable};
use dom::blob::Blob;
use servo_util::str::DOMString;

use js::jsapi::JSContext;
use js::jsapi::{JSContext, JSObject};
use js::jsval::{JSVal, NullValue};

#[dom_struct]
@@ -64,6 +64,7 @@ impl<'a> TestBindingMethods for JSRef<'a, TestBinding> {
fn SetUnionAttribute(self, _: HTMLElementOrLong) {}
fn Union2Attribute(self) -> EventOrString { eString("".to_string()) }
fn SetUnion2Attribute(self, _: EventOrString) {}
fn ArrayAttribute(self, _: *mut JSContext) -> *mut JSObject { NullValue().to_object_or_null() }
fn AnyAttribute(self, _: *mut JSContext) -> JSVal { NullValue() }
fn SetAnyAttribute(self, _: *mut JSContext, _: JSVal) {}

@@ -71,6 +71,7 @@ interface TestBinding {
attribute Blob interfaceAttribute;
attribute (HTMLElement or long) unionAttribute;
attribute (Event or DOMString) union2Attribute;
readonly attribute Uint8ClampedArray arrayAttribute;
attribute any anyAttribute;

attribute boolean? booleanAttributeNullable;

5 comments on commit 3036c8d

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 16, 2014

saw approval from Ms2ger
at ebalint@3036c8d

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 16, 2014

merging ebalint/servo/codegen = 3036c8d into auto

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 16, 2014

ebalint/servo/codegen = 3036c8d merged ok, testing candidate = 38a4e71

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 16, 2014

fast-forwarding master to auto = 38a4e71

Please sign in to comment.
You can’t perform that action at this time.