Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
style: Use Atomic<bool> for the staticpref version of layout.css.font…
…-variations.enabled.

Atomic<bool> is implemented in terms of AtomicBase<uint32_t>, because that way
you don't need to depend on atomic 1-byte operations.  That means that the rust
bindgen sees it as a u32, not a bool.

It's a bit concerning that the rust code seems to be doing an unsynchronized
read here, but given this is a RelaxedAtomic, that's probably ok.

Bug: 1467134
Reviewed-by: emilio
  • Loading branch information
bzbarsky authored and emilio committed Jun 12, 2018
1 parent 915c872 commit 3816143
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/style/font_face.rs
Expand Up @@ -323,7 +323,7 @@ macro_rules! is_descriptor_enabled {
("font-variation-settings") => {
unsafe {
use gecko_bindings::structs::mozilla;
mozilla::StaticPrefs_sVarCache_layout_css_font_variations_enabled
mozilla::StaticPrefs_sVarCache_layout_css_font_variations_enabled != 0
}
};
($name:tt) => {
Expand Down

0 comments on commit 3816143

Please sign in to comment.