Skip to content
Permalink
Browse files

more comments, remove unnecessary clone derive

  • Loading branch information...
gterzian committed Nov 8, 2019
1 parent 2daa999 commit 395faf7578692a8f124c2e385ffdb511f22d4a37
@@ -1016,7 +1016,7 @@ impl ScriptToConstellationChan {

/// A data-holder for serialized data and transferred objects.
/// <https://html.spec.whatwg.org/multipage/#structuredserializewithtransfer>
#[derive(Clone, Debug, Deserialize, MallocSizeOf, Serialize)]
#[derive(Debug, Deserialize, MallocSizeOf, Serialize)]
pub struct StructuredSerializedData {
/// Data serialized by SpiderMonkey.
pub serialized: Vec<u8>,
@@ -1025,7 +1025,7 @@ pub struct StructuredSerializedData {
}

/// A task on the https://html.spec.whatwg.org/multipage/#port-message-queue
#[derive(Clone, Debug, Deserialize, MallocSizeOf, Serialize)]
#[derive(Debug, Deserialize, MallocSizeOf, Serialize)]
pub struct PortMessageTask {
/// The origin of this task.
pub origin: ImmutableOrigin,
@@ -1036,9 +1036,9 @@ pub struct PortMessageTask {
/// Messages for communication between the constellation and a global managing ports.
#[derive(Debug, Deserialize, Serialize)]
pub enum MessagePortMsg {
/// Enables a port to catch-up on messages that were sent while the transfer was ongoing.
/// Complete the transfer for a batch of ports.
CompleteTransfer(HashMap<MessagePortId, VecDeque<PortMessageTask>>),
/// Complete a transfer for a port for previous transfer had failed.
/// Complete the transfer of a single port.
CompletePendingTransfer(MessagePortId, VecDeque<PortMessageTask>),
/// Remove a port, the entangled one doesn't exists anymore.
RemoveMessagePort(MessagePortId),
@@ -120,7 +120,8 @@ pub enum ScriptMsg {
CompleteMessagePortTransfer(MessagePortRouterId, Vec<MessagePortId>),
/// A transfer of ports was successfully completed.
MessagePortTransferCompleted(MessagePortRouterId, Vec<MessagePortId>),
/// The transfer of a list of ports message has failed.
/// A transfer of ports has failed.
/// Returns the buffer of tasks that was received for each port.
MessagePortTransferFailed(
MessagePortRouterId,
HashMap<MessagePortId, VecDeque<PortMessageTask>>,
@@ -11,7 +11,7 @@ use crate::PortMessageTask;
use msg::constellation_msg::MessagePortId;
use std::collections::VecDeque;

#[derive(Clone, Debug, Deserialize, MallocSizeOf, Serialize)]
#[derive(Debug, Deserialize, MallocSizeOf, Serialize)]
enum MessagePortState {
/// <https://html.spec.whatwg.org/multipage/#detached>
Detached,
@@ -25,7 +25,7 @@ enum MessagePortState {
Disabled(bool),
}

#[derive(Clone, Debug, Deserialize, MallocSizeOf, Serialize)]
#[derive(Debug, Deserialize, MallocSizeOf, Serialize)]
/// The data and logic backing the DOM managed MessagePort.
pub struct MessagePortImpl {
/// The current state of the port.

1 comment on commit 395faf7

@community-tc-integration

This comment has been minimized.

Copy link

community-tc-integration bot commented on 395faf7 Nov 8, 2019

Submitting the task to Taskcluster failed. Details

Taskcluster-GitHub attempted to create a task for this event with the following scopes:

[
  "assume:repo:github.com/servo/servo:pull-request",
  "queue:route:statuses",
  "queue:scheduler-id:taskcluster-github"
]

The expansion of these scopes is not sufficient to create the task, leading to the following:

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    {
      "AnyOf": [
        "queue:create-task:highest:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:very-high:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:high:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:medium:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:low:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:very-low:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:lowest:aws-provisioner-v1/servo-docker-untrusted"
      ]
    },
    {
      "AnyOf": [
        "queue:create-task:aws-provisioner-v1/servo-docker-untrusted",
        {
          "AllOf": [
            "queue:define-task:aws-provisioner-v1/servo-docker-untrusted",
            "queue:task-group-id:taskcluster-github/ObuvU-huSUeudIk96P-ktQ",
            "queue:schedule-task:taskcluster-github/ObuvU-huSUeudIk96P-ktQ/ObuvU-huSUeudIk96P-ktQ"
          ]
        }
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AllOf": [
    "assume:repo:github.com/servo/servo:pull-request",
    "queue:route:tc-treeherder.v2._/servo-prs.395faf7578692a8f124c2e385ffdb511f22d4a37",
    "queue:route:tc-treeherder-staging.v2._/servo-prs.395faf7578692a8f124c2e385ffdb511f22d4a37",
    "queue:route:statuses",
    {
      "AnyOf": [
        {
          "AllOf": [
            "queue:scheduler-id:taskcluster-github",
            {
              "AnyOf": [
                "queue:create-task:highest:aws-provisioner-v1/servo-docker-untrusted",
                "queue:create-task:very-high:aws-provisioner-v1/servo-docker-untrusted",
                "queue:create-task:high:aws-provisioner-v1/servo-docker-untrusted",
                "queue:create-task:medium:aws-provisioner-v1/servo-docker-untrusted",
                "queue:create-task:low:aws-provisioner-v1/servo-docker-untrusted",
                "queue:create-task:very-low:aws-provisioner-v1/servo-docker-untrusted",
                "queue:create-task:lowest:aws-provisioner-v1/servo-docker-untrusted"
              ]
            }
          ]
        },
        {
          "AnyOf": [
            "queue:create-task:aws-provisioner-v1/servo-docker-untrusted",
            {
              "AllOf": [
                "queue:define-task:aws-provisioner-v1/servo-docker-untrusted",
                "queue:task-group-id:taskcluster-github/ObuvU-huSUeudIk96P-ktQ",
                "queue:schedule-task:taskcluster-github/ObuvU-huSUeudIk96P-ktQ/ObuvU-huSUeudIk96P-ktQ"
              ]
            }
          ]
        }
      ]
    }
  ]
}

  • method: createTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2019-11-08T12:48:07.986Z
Please sign in to comment.
You can’t perform that action at this time.