Please sign in to comment.
style: Implement CSS revert keyword.
The only fishy bit is the animation stuff. In particular, there are two places where we just mint the revert behavior: * When serializing web-animations keyframes (the custom properties stuff in declaration_block.rs). That codepath is already not sound and I wanted to get rid of it in bug 1501530, but what do I know. * When getting an animation value from a property declaration. At that point we no longer have the CSS rules that apply to the element to compute the right revert value handy. It'd also use the wrong style anyway, I think, given the way StyleBuilder::for_animation works. We _could_ probably get them out of somewhere, but it seems like a whole lot of code reinventing the wheel which is probably not useful, and that Blink and WebKit just cannot implement either since they don't have a rule tree, so it just doesn't seem worth the churn. The custom properties code looks a bit different in order to minimize hash lookups in the common case. FWIW, `revert` for custom properties doesn't seem very useful either, but oh well. Differential Revision: https://phabricator.services.mozilla.com/D21877
- Loading branch information...
Showing with 119 additions and 20 deletions.
- +28 −6 components/style/custom_properties.rs
- +20 −9 components/style/properties/cascade.rs
- +1 −1 components/style/properties/declaration_block.rs
- +1 −0 components/style/properties/helpers.mako.rs
- +9 −0 components/style/properties/helpers/animated_properties.mako.rs
- +11 −0 components/style/properties/properties.mako.rs
- +22 −1 components/style/rule_tree/mod.rs
- +26 −2 components/style/stylesheets/origin.rs
- +1 −1 components/style/values/mod.rs