Skip to content
Permalink
Browse files

add the gecko_debug feature

debug_assertions is not a reliable guide to whether Gecko C++ code is
being compiled with debugging assertions, since we can now compile Gecko
with --enable-optimize --disable-debug --enable-rust-debug: Gecko will
be compiled without debugging assertions (and debugging struct layouts)
and Rust code will be compiled with debug_assertions.  The struct
mismatches in the binding layer lead to startup crashes.

This feature is not presently used, but will be set by some Gecko-side
changes and then used by some Servo-side changes.  These changes need to
be made first so that CI on both sides works correctly at all
intermediate stages along the way.
  • Loading branch information...
froydnj committed Apr 20, 2017
1 parent 26fd659 commit 7249d5f4f1fdf069c2c020fcd61b63ad032ca537
Showing with 2 additions and 0 deletions.
  1. +1 −0 components/style/Cargo.toml
  2. +1 −0 ports/geckolib/Cargo.toml
@@ -20,6 +20,7 @@ servo = ["serde/unstable", "serde", "serde_derive", "heapsize", "heapsize_derive
"cssparser/heapsize", "cssparser/serde", "encoding",
"rayon/unstable", "servo_url"]
testing = []
gecko_debug = []

[dependencies]
app_units = "0.4"
@@ -12,6 +12,7 @@ crate-type = ["staticlib", "rlib"]
[features]
bindgen = ["style/use_bindgen"]
testing = ["style/testing"]
gecko_debug = ["style/gecko_debug"]

[dependencies]
atomic_refcell = "0.1"

0 comments on commit 7249d5f

Please sign in to comment.
You can’t perform that action at this time.